Issue 15912007: WIP - loop in LayoutManager for preferred size changes (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15912007: WIP - loop in LayoutManager for preferred size changes (2) (Closed)

Created:
7 years, 7 months ago by Evan Stade

Modified:
5 years, 3 months ago

Reviewers:

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WIP - loop in LayoutManager for preferred size changes also do a defered layout in InvalidateLayout BUG=

Patch Set 2 : fix LabelTest #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -24 lines)			Patch
M	ui/views/controls/label_unittest.cc	View	1	19 chunks	+29 lines, -19 lines	1 comment	Download
M	ui/views/layout/box_layout.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/layout/box_layout.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/layout/layout_manager.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/views/layout/layout_manager.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	ui/views/view.h	View		6 chunks	+10 lines, -2 lines	0 comments	Download
M	ui/views/view.cc	View		4 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

https://codereview.chromium.org/15912007/diff/3001/ui/views/controls/label_unittest.cc File ui/views/controls/label_unittest.cc (right): https://codereview.chromium.org/15912007/diff/3001/ui/views/controls/label_unittest.cc#newcode20 ui/views/controls/label_unittest.cc:20: class LabelTest : public testing::Test { some views_unittests will ...

7 years, 7 months ago (2013-05-23 21:45:58 UTC) #2

sky

When I mentioned this to Ben after your last patch he was a bit skeptical ...

7 years, 7 months ago (2013-05-23 21:58:55 UTC) #3