Issue 15912004: Add private API to notify end of initialization.

Issue 15912004: Add private API to notify end of initialization. (Closed)

Created:
7 years, 7 months ago by Seigo Nonaka

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Zachary Kuznia, Matt Perry

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add private API to notify end of initialization. To be able to use input method just after log-in, we should notify the end of ime initialization to input method engine, otherwise onActivate event will be missed. The right way to fix this issue is migrating packaged app and working with lazy background page, but it requires much effort both for chrome and extension side so and hard to merge to M28. So please let me add this temporary hack. BUG=242864 TEST=Manually checked on link Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202842

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressing comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -1 line)			Patch
M	chrome/browser/chromeos/extensions/input_method_api.h	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/input_method_api.cc	View		3 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_histogram_value.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/api/_permission_features.json	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/input_method_private.json	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

Thank you for your review! Adding mpcomplete@ as the owner of extension. Hi Matt, could ...

7 years, 7 months ago (2013-05-27 13:38:27 UTC) #3

Matt Perry

lgtm https://codereview.chromium.org/15912004/diff/6001/chrome/browser/extensions/extension_function_histogram_value.h File chrome/browser/extensions/extension_function_histogram_value.h (right): https://codereview.chromium.org/15912004/diff/6001/chrome/browser/extensions/extension_function_histogram_value.h#newcode533 chrome/browser/extensions/extension_function_histogram_value.h:533: NOTIFICATIONS_GET_ALL, remove this. merge mixup?

7 years, 6 months ago (2013-05-28 18:54:38 UTC) #4

Seigo Nonaka

Thank you for your review! https://codereview.chromium.org/15912004/diff/6001/chrome/browser/extensions/extension_function_histogram_value.h File chrome/browser/extensions/extension_function_histogram_value.h (right): https://codereview.chromium.org/15912004/diff/6001/chrome/browser/extensions/extension_function_histogram_value.h#newcode533 chrome/browser/extensions/extension_function_histogram_value.h:533: NOTIFICATIONS_GET_ALL, On 2013/05/28 18:54:38, ...

7 years, 6 months ago (2013-05-29 03:51:54 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/15912004/15001

7 years, 6 months ago (2013-05-29 03:52:02 UTC) #6

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 6 months ago (2013-05-29 04:04:27 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/15912004/15001

7 years, 6 months ago (2013-05-29 04:18:48 UTC) #8

Message was sent while issue was closed.

Change committed as 202842

Expand Messages | Collapse Messages