RulesRegistryWithCache::ProcessChangedRules postponed

chrome/browser/extensions/api/declarative/rules_registry_with_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_RULES_REGISTRY_WITH_CACHE_H__
 #define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_RULES_REGISTRY_WITH_CACHE_H__
 
 #include "chrome/browser/extensions/api/declarative/rules_registry.h"
 
 #include <map>
@@ skipping 158 matching lines @@
       const std::vector<std::string>& rule_identifiers) = 0;
   virtual std::string RemoveAllRulesImpl(
       const std::string& extension_id) = 0;
 
  private:
   typedef std::string ExtensionId;
   typedef std::string RuleId;
   typedef std::pair<ExtensionId, RuleId> RulesDictionaryKey;
   typedef std::map<RulesDictionaryKey, linked_ptr<RulesRegistry::Rule> >
       RulesDictionary;
+  enum ProcessChangedRulesState {
+    NEVER_PROCESS,
+    SCHEDULED_FOR_PROCESSING,
+    NOT_SCHEDULED_FOR_PROCESSING
+  };
 
   // Common processing after extension's rules have changed.
   void ProcessChangedRules(const std::string& extension_id);
 
+  // Calls ProcessChangedRules if |process_changed_rules_requested_| ==
+  // NOT_SCHEDULED_FOR_PROCESSING.
+  void MaybeProcessChangedRules(const std::string& extension_id);
+
   // Process the callbacks once the registry gets ready.
   void MarkReady(base::Time storage_init_time);
 
   // Deserialize the rules from the given Value object and add them to the
   // RulesRegistry.
   void DeserializeAndAddRules(const std::string& extension_id,
                               scoped_ptr<base::Value> rules);
 
 
   RulesDictionary rules_;
 
   // Signaled when we have finished reading from storage for all extensions that
   // are loaded on startup.
   OneShotEvent ready_;
 
   // The factory needs to be declared before |storage_on_ui_|, so that it can
   // produce a pointer as a construction argument for |storage_on_ui_|.
   base::WeakPtrFactory<RulesRegistryWithCache> weak_ptr_factory_;
 
   // |storage_on_ui_| is owned by the registry service. If |storage_on_ui_| is
   // NULL, then the storage functionality is disabled (this is used in tests).
   // This registry cannot own |storage_on_ui_| because during the time after
   // rules registry service shuts down on UI thread, and the registry is
   // destroyed on its thread, the use of the |storage_on_ui_| would not be
   // safe. The registry only ever associates with one RuleStorageOnUI instance.
   const base::WeakPtr<RuleStorageOnUI> storage_on_ui_;
 
+  // Possible values:
+  // NEVER_PROCESS -- ProcessChangedRules can never be called, because
+  // |storage_on_ui_| is NULL.
+  // SCHEDULED_FOR_PROCESSING -- a task to call ProcessChangedRules is scheduled
+  // for execution in the future.
+  // NOT_SCHEDULED_FOR_PROCESSING -- no task to call ProcessChangedRules is
+  // scheduled yet, but it is possible to schedule one.

[battre, 2013/06/04 08:22:34]

nit: I think this should go to the typedef above.

+  ProcessChangedRulesState process_changed_rules_requested_;
+
   DISALLOW_COPY_AND_ASSIGN(RulesRegistryWithCache);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_RULES_REGISTRY_WITH_CACHE_H__