Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1591053003: Fix to bottom bar behavior (Closed)

Created:
4 years, 11 months ago by Yusuf
Modified:
4 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix to bottom bar behavior - Add a new extra for the bottom bar buttons - Use the above to distinguish between old and new API calls so that all permutations of support lib and chrome versions work - Add accesibility support for bottom bar - Have the bottom bar pending intents sent back with the current url BUG=573683 Committed: https://crrev.com/92d77538a86529ca35f9220bd3cd512cbea1f086 Cr-Commit-Position: refs/heads/master@{#369907}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -20 lines) Patch
M chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomButtonParams.java View 6 chunks +28 lines, -18 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 3 chunks +21 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Yusuf
4 years, 11 months ago (2016-01-15 23:20:13 UTC) #2
Ted C
lgtm https://codereview.chromium.org/1591053003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomButtonParams.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomButtonParams.java (right): https://codereview.chromium.org/1591053003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomButtonParams.java#newcode142 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomButtonParams.java:142: view.getResources().getDimensionPixelSize( FYI, this will be wrong in multiwindow
4 years, 11 months ago (2016-01-15 23:28:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591053003/1
4 years, 11 months ago (2016-01-15 23:29:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591053003/20001
4 years, 11 months ago (2016-01-16 00:18:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-16 01:22:43 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 01:24:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92d77538a86529ca35f9220bd3cd512cbea1f086
Cr-Commit-Position: refs/heads/master@{#369907}

Powered by Google App Engine
This is Rietveld 408576698