chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html - Issue 1591053002: Add a password handler to get the list of passwords in md-settings.

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 1591053002: Add a password handler to get the list of passwords in md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chrome.passwordsPrivate Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js ('K') | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.css ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js » ('j') | chrome/test/data/webui/settings/settings_passwords_section_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

index 47d9d61565d0206582bc26b577fbd7fd584e7336..233e570cbbe81bfb370c61d6ed272b323f081010 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

@@ -1,5 +1,6 @@

+<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">

@@ -14,10 +15,17 @@

<paper-item class="separator">

<paper-item-body two-line>

- <div id="origin">[[item.origin]]</div>

- <div id="username"secondary>[[item.username]]</div>

+ <div id="shownUrl">[[item.loginPair.originUrl]]</div>

Dan Beam 2016/01/27 00:17:45 why is "shownUrl" better?

hcarmona 2016/01/27 02:46:18 It's arbitrary, I've changed it to "originUrl" to

+ <div id="username"secondary>[[item.loginPair.username]]</div>

</paper-item-body>

- <div id="password">[[item.password]]</div>

+ <!--

+ TODO(hcarmona): Update password so that it is editable.

+ #password is type password and disabled in order to match UI.

+ -->

Dan Beam 2016/01/27 00:17:45  IMO

hcarmona 2016/01/27 02:46:18 Done.

+ <paper-input id="password" type="password" disabled

+ class="readonly-password"

+ value="[[getEmptyPassword(item.numCharactersInPassword)]]">

Dan Beam 2016/01/27 00:17:45 nit: getEmptyPassword_ (private if possible)

hcarmona 2016/01/27 02:46:18 Done.

+ </paper-input>

</paper-item>

</template>

</iron-list>