Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Issue 1591053002: Add a password handler to get the list of passwords in md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback + closure compile Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
index b46e9fb3b2389df1a434bc8350d6d947227cd203..bafb5fe47950ed962dc72c57c19d7121a5da4f5b 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
@@ -50,17 +50,12 @@ Polymer({
*/
loadPasswords_: function(passwordSectionOpened) {
if (passwordSectionOpened) {
- // TODO(hcarmona): Get real data.
- this.savedPasswords =
- [{origin: 'otherwebsite.com',
- username: 'bowser',
- password: '************'},
- {origin: 'otherlongwebsite.com',
- username: 'koopa',
- password: '*********'},
- {origin: 'otherverylongwebsite.com',
- username: 'goomba',
- password: '******'}];
+ settings.PasswordsPrivateApi.updatePasswordLists(function(passwordList) {
michaelpg 2016/01/16 07:12:48 nit: newline before "function" to make indentation
hcarmona 2016/01/20 02:32:50 Done.
+ this.savedPasswords = passwordList;
michaelpg 2016/01/16 07:12:48 2-space indent (but see above)
hcarmona 2016/01/20 02:32:50 Done.
+ }.bind(this),
+ function(exceptionList) {
michaelpg 2016/01/16 07:12:48 these should be 4 space indent because they contin
hcarmona 2016/01/20 02:32:50 Done.
+ // TODO(hcarmona): Populate the password exceptions here.
+ });
}
},
});

Powered by Google App Engine
This is Rietveld 408576698