third_party/WebKit/LayoutTests/fast/table/div-height-inside-auto-table-cell-is-auto.html - Issue 1591043002: Treat percent-height boxes inside auto-height cells as auto

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/div-height-inside-auto-table-cell-is-auto.html

Issue 1591043002: Treat percent-height boxes inside auto-height cells as auto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@3_cell_height

Patch Set: make layout tests all pass Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/div-height-inside-auto-table-cell-is-auto-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <style>

	3 #parent {

	4 height: 100px;

	5 width: 100px;

	6 }

	7

	8 #child {

	9 height: 100%;

	10 width: 100%;

	11 background: red;

	12 }

	13 </style>

	14

	15 There should be no red square below.

	16 <table id="parent">

	17 <tr>

	18 <td>

	19 <div id="child" data-expected-height="0"></div>

	20 </td>

	21 </tr>

	22 </table>

	23

	24 <script src="../../resources/check-layout.js"></script>

	25 <script>

	26 checkLayout('#child');
	mstensho (USE GERRIT) 2016/01/21 20:21:33 I suggest that you check #parent instead (which wi I suggest that you check #parent instead (which will traverse the entire subtree). The test results text is dumped into a sibling node of what you specify here, so currently the text messes up the table layout. The test will still pass and fail as it should with #child here, but it's less human-friendly that way. :) dgrogan 2016/01/22 00:08:09 Good call. Done. Show quoted text On 2016/01/21 20:21:33, mstensho wrote: > I suggest that you check #parent instead (which will traverse the entire > subtree). The test results text is dumped into a sibling node of what you > specify here, so currently the text messes up the table layout. The test will > still pass and fail as it should with #child here, but it's less human-friendly > that way. :) Good call. Done.
	27 </script>

OLD	NEW