Add toV8(value, scriptState)

third_party/WebKit/Source/bindings/core/v8/ToV8.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ToV8_h
 #define ToV8_h
 
 // toV8() provides C++ -> V8 conversion. Note that toV8() can return an empty
 // handle. Call sites must check IsEmpty() before using return value.
 
 #include "bindings/core/v8/DOMDataStore.h"
+#include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "core/CoreExport.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Forward.h"
 #include <v8.h>
 
 namespace blink {
 
@@ skipping 212 matching lines @@
     for (unsigned i = 0; i < value.size(); ++i) {
         v8::Local<v8::Value> v8Value = toV8(value[i].second, creationContext, isolate);
         if (v8Value.IsEmpty())
             v8Value = v8::Undefined(isolate);
         if (!v8CallBoolean(object->Set(isolate->GetCurrentContext(), v8String(isolate, value[i].first), v8Value)))
             return v8::Local<v8::Value>();
     }
     return object;
 }
 
+// In all cases allow script state instead of creation context + isolate.
+// Only use if your function does not otherwise need the global, as
+// v8::Context::Global() is not simply a getter.

[haraken, 2016/01/16 03:51:22]

What do you mean by "v8::Context::Global() is not simply a getter"?

+template<typename T>
+inline v8::Local<v8::Value> toV8(T value, ScriptState* scriptState)

[yhirano, 2016/01/17 23:51:38]

Is "T&&" better for avoiding copy?

+{
+    return toV8(value, scriptState->context()->Global(), scriptState->isolate());
+}
+
 // Only declare toV8(void*,...) for checking function overload mismatch.
 // This toV8(void*,...) should be never used. So we will find mismatch
 // because of "unresolved external symbol".
 // Without toV8(void*, ...), call to toV8 with T* will match with
 // toV8(bool, ...) if T is not a subclass of ScriptWrappable or if T is
 // declared but not defined (so it's not clear that T is a subclass of
 // ScriptWrappable).
 // This hack helps detect such unwanted implicit conversions from T* to bool.
 v8::Local<v8::Value> toV8(void* value, v8::Local<v8::Object> creationContext, v8::Isolate*) = delete;
 
 } // namespace blink
 
 #endif // ToV8_h