Issue 1591013: Fix drag&drop layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1591013: Fix drag&drop layout tests. (Closed)

Created:
10 years, 8 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Visibility:
Public.

Description

Fix drag&drop layout tests. https://bugs.webkit.org/attachment.cgi?id=52445&action=review changed the WebViewClient interface, and http://codereview.chromium.org/1037008 adapted the chrome side, but test shell was not updated. estade improved & landed this in http://codereview.chromium.org/1519018 .

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	webkit/tools/test_shell/test_webview_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	webkit/tools/test_shell/test_webview_delegate.cc	View	1	4 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Nico

10 years, 8 months ago (2010-04-04 17:38:02 UTC) #1

Hi Evan,

something like this is required to fix the layout tests after your
https://bugs.webkit.org/show_bug.cgi?id=35811 patch. Since the WebPoint changed
its meaning from mouse_pos to image_offset, EventSendingController::DoDragDrop()
probably has to be changed as well (or both position and offset need to be
passed).

I'm having troubles running layout tests locally, so maybe you can take this
from here?

Thanks,
Nico

Expand Messages | Collapse Messages