Chromium Code Reviews
Help | Chromium Project | Sign in
(55)

Issue 1591006: Adds support for the <keygen> element to Windows, matching... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by wtc
Modified:
3 years, 11 months ago
Reviewers:
rsleevi-old
CC:
chromium-reviews, pam+watch_chromium.org, John Grabowski, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Adds support for the <keygen> element to Windows, matching support present on Linux and Mac OS X. Contributed by Ryan Sleevi <ryan.sleevi@gmail.com>;. Original review URL: http://codereview.chromium.org/843005 R=wtc BUG=148 TEST=KeygenHandler.SmokeTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43365

Patch Set 1 #

Patch Set 2 : Add keygen_handler.cc. Fix nits. #

Patch Set 3 : Fix Location=>KeyLocation in keygen_handler_unittest.cc. Sync AUTHORS. #

Patch Set 4 : Fix keygen_handler_nss.cc compilation errors. Fix more nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+633 lines, -43 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/base/cert_database.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/base/cert_database_mac.cc View 1 3 chunks +4 lines, -6 lines 0 comments Download
M net/base/cert_database_nss.cc View 1 3 chunks +4 lines, -7 lines 0 comments Download
M net/base/cert_database_win.cc View 1 2 3 1 chunk +101 lines, -9 lines 0 comments Download
M net/base/keygen_handler.h View 1 2 3 2 chunks +53 lines, -1 line 0 comments Download
A net/base/keygen_handler.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M net/base/keygen_handler_mac.cc View 1 4 chunks +8 lines, -3 lines 0 comments Download
M net/base/keygen_handler_nss.cc View 1 2 3 3 chunks +23 lines, -6 lines 0 comments Download
M net/base/keygen_handler_unittest.cc View 1 2 2 chunks +42 lines, -0 lines 0 comments Download
M net/base/keygen_handler_win.cc View 1 2 3 1 chunk +355 lines, -3 lines 0 comments Download
M net/base/net_error_list.h View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 2 chunks +1 line, -4 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
wtc
Ryan, Patch Set 1 is your original changelist. I will edit it for style nits ...
5 years ago (2010-04-01 02:00:09 UTC) #1
wtc
5 years ago (2010-04-01 03:31:56 UTC) #2
Ryan:

Please review the diffs between Patch Set 3 and Patch Set 1.
You should be able to figure out the rules behind the changes.

The only thing that needs explaining is that I try to cap line
length at 78 (even though style guide allows 80) so that when
doing diffs (which add +/- and possibly a space) the lines
still won't wrap.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 700cc9d