Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: appengine/findit/waterfall/try_job_pipeline.py

Issue 1591003002: [Findit] Modify tryjob pipelines to trigger try jobs for test failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/try_job_pipeline.py
diff --git a/appengine/findit/waterfall/try_job_pipeline.py b/appengine/findit/waterfall/try_job_pipeline.py
index c4de162c89ef72e700f4ae70f72e54c4430690b3..396f47d977630a7004d2642aebc88dea576cd364 100644
--- a/appengine/findit/waterfall/try_job_pipeline.py
+++ b/appengine/findit/waterfall/try_job_pipeline.py
@@ -14,17 +14,22 @@ from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline
class TryJobPipeline(BasePipeline):
"""Root pipeline to start a tryjob on current build."""
- def __init__(self, master_name, builder_name, build_number,
- good_revision, bad_revision, compile_targets):
+ def __init__(
+ self, master_name, builder_name, build_number,
+ good_revision, bad_revision, blame_list, try_job_type,
+ compile_targets=None, targeted_tests=None):
super(TryJobPipeline, self).__init__(
master_name, builder_name, build_number, good_revision, bad_revision,
- compile_targets)
+ blame_list, try_job_type, compile_targets, targeted_tests)
self.master_name = master_name
self.builder_name = builder_name
self.build_number = build_number
self.good_revision = good_revision
self.bad_revision = bad_revision
+ self.blame_list = blame_list
+ self.try_job_type = try_job_type
self.compile_targets = compile_targets
+ self.targeted_tests = targeted_tests
def _LogUnexpectedAbort(self, was_aborted):
"""Marks the WfTryJob status as error, indicating that it was aborted.
@@ -46,12 +51,13 @@ class TryJobPipeline(BasePipeline):
# Arguments number differs from overridden method - pylint: disable=W0221
def run(
- self, master_name, builder_name, build_number,
- good_revision, bad_revision, compile_targets):
+ self, master_name, builder_name, build_number, good_revision,
+ bad_revision, blame_list, try_job_type, compile_targets, targeted_tests):
try_job_id = yield ScheduleTryJobPipeline(
master_name, builder_name, build_number, good_revision, bad_revision,
- compile_targets)
- compile_result = yield MonitorTryJobPipeline(
- master_name, builder_name, build_number, try_job_id)
+ try_job_type, compile_targets, targeted_tests)
+ try_job_result = yield MonitorTryJobPipeline(
+ master_name, builder_name, build_number, try_job_type, try_job_id)
yield IdentifyTryJobCulpritPipeline(
- master_name, builder_name, build_number, try_job_id, compile_result)
+ master_name, builder_name, build_number, blame_list, try_job_type,
+ try_job_id, try_job_result)

Powered by Google App Engine
This is Rietveld 408576698