Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: appengine/findit/model/test/wf_try_job_test.py

Issue 1591003002: [Findit] Modify tryjob pipelines to trigger try jobs for test failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: If different tests within the same step fail in different revisions, all revisions should be culpri… Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/test/wf_try_job_test.py
diff --git a/appengine/findit/model/test/wf_try_job_test.py b/appengine/findit/model/test/wf_try_job_test.py
index b16972a79e53c7e40895d5985b5444ad5c9a70c0..565e00906aa6db0220c792752420c0a123a9446b 100644
--- a/appengine/findit/model/test/wf_try_job_test.py
+++ b/appengine/findit/model/test/wf_try_job_test.py
@@ -11,24 +11,24 @@ from model.wf_try_job import WfTryJob
class WfTryJobTest(unittest.TestCase):
def testWfTryJobStatusIsCompleted(self):
for status in (wf_analysis_status.ANALYZED, wf_analysis_status.ERROR):
- tryjob = WfTryJob.Create('m', 'b', 123)
- tryjob.status = status
- self.assertTrue(tryjob.completed)
+ try_job = WfTryJob.Create('m', 'b', 123)
stgao 2016/01/26 00:51:40 If you like, the rename here and in other files co
chanli 2016/01/27 18:49:55 Got it. Done.
+ try_job.status = status
+ self.assertTrue(try_job.completed)
def testWfTryJobStatusIsNotCompleted(self):
for status in (wf_analysis_status.PENDING, wf_analysis_status.ANALYZING):
- tryjob = WfTryJob.Create('m', 'b', 123)
- tryjob.status = status
- self.assertFalse(tryjob.completed)
+ try_job = WfTryJob.Create('m', 'b', 123)
+ try_job.status = status
+ self.assertFalse(try_job.completed)
def testWfTryJobStatusIsFailed(self):
- tryjob = WfTryJob.Create('m', 'b', 123)
- tryjob.status = wf_analysis_status.ERROR
- self.assertTrue(tryjob.failed)
+ try_job = WfTryJob.Create('m', 'b', 123)
+ try_job.status = wf_analysis_status.ERROR
+ self.assertTrue(try_job.failed)
def testWfTryJobStatusIsNotFailed(self):
for status in (wf_analysis_status.PENDING, wf_analysis_status.ANALYZING,
wf_analysis_status.ANALYZED):
- tryjob = WfTryJob.Create('m', 'b', 123)
- tryjob.status = status
- self.assertFalse(tryjob.failed)
+ try_job = WfTryJob.Create('m', 'b', 123)
+ try_job.status = status
+ self.assertFalse(try_job.failed)

Powered by Google App Engine
This is Rietveld 408576698