[Findit] Modify tryjob pipelines to trigger try jobs for test failure.

appengine/findit/waterfall/monitor_try_job_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import time
 
 from common import buildbucket_client
 from model import wf_analysis_status
 from model.wf_try_job import WfTryJob
 from pipeline_wrapper import BasePipeline
 from pipeline_wrapper import pipeline
 
 
 class MonitorTryJobPipeline(BasePipeline):
   """A pipeline for monitoring a tryjob and recording results when it's done.
 
   The result will be stored to compile_results or test_results according to
   which type of build failure we are running try job for.
   """
 
   # Arguments number differs from overridden method - pylint: disable=W0221
   # TODO(chanli): Handle try job for test failures later.
-  def run(self, master_name, builder_name, build_number, try_job_id):
+  def run(
+      self, master_name, builder_name, build_number, try_job_type, try_job_id):
     assert try_job_id
 
     timeout_hours = 5  # Timeout after 5 hours.
     deadline = time.time() + timeout_hours * 60 * 60
 
     already_set_started = False
     while True:
       error, build = buildbucket_client.GetTryJobs([try_job_id])[0]
       if error:  # pragma: no cover
         raise pipeline.Retry(
             'Error "%s" occurred. Reason: "%s"' % (error.message, error.reason))
       elif build.status == 'COMPLETED':
         result = {
             'result': build.result,
             'url': build.url,
             'try_job_id': try_job_id,
         }
 
         try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
-        if (try_job_result.compile_results and
-            try_job_result.compile_results[-1]['try_job_id'] == try_job_id):
-          try_job_result.compile_results[-1].update(result)
+        if try_job_type == 'compile':
+          result_needs_update = try_job_result.compile_results
+        else:
+          result_needs_update = try_job_result.test_results
+        if (result_needs_update and
+            result_needs_update[-1]['try_job_id'] == try_job_id):
+          result_needs_update[-1].update(result)
         else:  # pragma: no cover
-          try_job_result.compile_results.append(result)
+          result_needs_update.append(result)
+        try_job_result.put()
+        return result_needs_update[-1]
 
-        try_job_result.put()
-        return try_job_result.compile_results[-1]
       else:  # pragma: no cover
         if build.status == 'STARTED' and not already_set_started:
           result = {
               'result': None,
               'url': build.url,
               'try_job_id': try_job_id,
           }
 
           try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
-          if (try_job_result.compile_results and
-              try_job_result.compile_results[-1]['try_job_id'] == try_job_id):
-            try_job_result.compile_results[-1].update(result)
+          if try_job_type == 'compile':
+            result_needs_update = try_job_result.compile_results
+          else:
+            result_needs_update = try_job_result.test_results
+          if (result_needs_update and
+              result_needs_update[-1]['try_job_id'] == try_job_id):
+            result_needs_update[-1].update(result)
           else:  # pragma: no cover
             # Normally result for current try job should've been saved in
             # schedule_try_job_pipeline, so this branch shouldn't be reached.
-            try_job_result.compile_results.append(result)
+            result_needs_update.append(result)
 
           try_job_result.status = wf_analysis_status.ANALYZING
           try_job_result.put()
           already_set_started = True
 
         time.sleep(60)
 
       if time.time() > deadline:  # pragma: no cover
         try_job_result.status = wf_analysis_status.ERROR
         try_job_result.put()
         # Explicitly abort the whole pipeline.
         raise pipeline.Abort(
             'Try job %s timed out after %d hours.' % (
                 try_job_id, timeout_hours))