[Findit] Modify tryjob pipelines to trigger try jobs for test failure.

appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from testing_utils import testing
 
 from common import buildbucket_client
 from model.wf_try_job import WfTryJob
 from waterfall import waterfall_config
 from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline
+from waterfall.try_job_enums import TryJobType
 
 
 class ScheduleTryjobPipelineTest(testing.AppengineTestCase):
 
   def _Mock_GetTrybotForWaterfallBuilder(self, *_):
     def Mocked_GetTrybotForWaterfallBuilder(*_):
       return 'linux_chromium_variable', 'master.tryserver.chromium.linux'
     self.mock(waterfall_config, 'GetTrybotForWaterfallBuilder',
               Mocked_GetTrybotForWaterfallBuilder)
 
   def _Mock_TriggerTryJobs(self, responses):
     def Mocked_TriggerTryJobs(*_):
       results = []
       for response in responses:
         if response.get('error'):  # pragma: no cover
           results.append((
               buildbucket_client.BuildbucketError(response['error']), None))
         else:
           results.append((
               None, buildbucket_client.BuildbucketBuild(response['build'])))
       return results
     self.mock(buildbucket_client, 'TriggerTryJobs', Mocked_TriggerTryJobs)
 
   def testGetBuildPropertiesWithCompileTargets(self):
     master_name = 'm'
     builder_name = 'b'
-    recipe = 'a/b/recipe'
     compile_targets = ['a.exe']
 
     expected_properties = {
-        'recipe': recipe,
+        'recipe': 'findit/chromium/compile',
         'good_revision': 1,
         'bad_revision': 2,
         'target_mastername': master_name,
         'target_buildername': 'b',
         'compile_targets': compile_targets
     }
     try_job_pipeline = ScheduleTryJobPipeline()
     properties = try_job_pipeline._getBuildProperties(
-        recipe, master_name, builder_name, 1, 2, compile_targets)
+        master_name, builder_name, 1, 2, TryJobType.type_compile,
+        compile_targets, None)
 
     self.assertEqual(properties, expected_properties)
 
+  def testGetBuildPropertiesForTestFailure(self):
+    master_name = 'm'
+    builder_name = 'b'
+    targeted_tests = {'a':[]}
+
+    expected_properties = {
+        'recipe': 'findit/chromium/test',
+        'good_revision': 1,
+        'bad_revision': 2,
+        'target_mastername': master_name,
+        'target_testername': 'b',
+        'tests': targeted_tests
+    }
+    try_job_pipeline = ScheduleTryJobPipeline()
+    properties = try_job_pipeline._getBuildProperties(
+        master_name, builder_name, 1, 2, TryJobType.type_test,
+        None, targeted_tests)
+
+    self.assertEqual(properties, expected_properties)
+
   def testSuccessfullyScheduleNewTryJobForCompile(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 223
     good_revision = 'rev1'
     bad_revision = 'rev2'
 
     responses = [
         {
             'build': {
                 'id': '1',
                 'url': 'url',
                 'status': 'SCHEDULED',
             }
         }
     ]
     self._Mock_GetTrybotForWaterfallBuilder(master_name, builder_name)
     self._Mock_TriggerTryJobs(responses)
 
     WfTryJob.Create(master_name, builder_name, build_number).put()
 
     try_job_pipeline = ScheduleTryJobPipeline()
     try_job_id = try_job_pipeline.run(
         master_name, builder_name, build_number, good_revision, bad_revision,
-        [])
+        TryJobType.type_compile, None, None)
 
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
     self.assertEqual('1', try_job_id)
     self.assertEqual('1', try_job.compile_results[-1]['try_job_id'])
+
+
+  def testSuccessfullyScheduleNewTryJobForTest(self):
+    master_name = 'm'
+    builder_name = 'b'
+    build_number = 223
+    good_revision = 'rev1'
+    bad_revision = 'rev2'
+    targeted_tests = ['browser_test']

[stgao, 2016/01/28 19:33:52]

Shouldn't we specify the testcase list too?

[chanli, 2016/01/28 22:40:12]

This test is just to test starting a tryjob for test with right parameters. I
don't think it's necessary to make the targeted_test multiple layers, it's not
so relevant to this test.

+
+    responses = [
+        {
+            'build': {
+                'id': '1',
+                'url': 'url',
+                'status': 'SCHEDULED',
+            }
+        }
+    ]
+    self._Mock_GetTrybotForWaterfallBuilder(master_name, builder_name)
+    self._Mock_TriggerTryJobs(responses)
+
+    WfTryJob.Create(master_name, builder_name, build_number).put()
+
+    try_job_pipeline = ScheduleTryJobPipeline()
+    try_job_id = try_job_pipeline.run(
+        master_name, builder_name, build_number, good_revision, bad_revision,
+        TryJobType.type_test, None, targeted_tests)
+
+    try_job = WfTryJob.Get(master_name, builder_name, build_number)
+    self.assertEqual('1', try_job_id)
+    self.assertEqual('1', try_job.test_results[-1]['try_job_id'])