appengine/findit/.gitignore - Issue 1591003002: [Findit] Modify tryjob pipelines to trigger try jobs for test failure.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/.gitignore

Issue 1591003002: [Findit] Modify tryjob pipelines to trigger try jobs for test failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: If different tests within the same step fail in different revisions, all revisions should be culpri… Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 # no file in .tmp/

1 .tmp	2 .tmp

	3

	4 # no file in util_scripts/

	5 util_scripts

	6

	7 # but do track run.sh
	stgao 2016/01/26 00:51:40 Does this work? See the conditions 3 and 4 below. Does this work? See the conditions 3 and 4 below. (https://git-scm.com/docs/gitignore) To re-include files or directories when their parent directory is excluded, the following conditions must be met: 1. The rules to exclude a directory and re-include a subset back must be in the same .gitignore file. 2. The directory part in the re-include rules must be literal (i.e. no wildcards) 3. The rules to exclude the parent directory must not end with a trailing slash. 4. The rules to exclude the parent directory must have at least one slash. stgao 2016/01/26 00:51:40 As this is not relative to the main purpose of thi As this is not relative to the main purpose of this CL, maybe create a separate CL for it? stgao 2016/01/26 00:51:40 This comment might be misleading, as we need to tr This comment might be misleading, as we need to track more than run.sh chanli 2016/01/27 18:49:54 It works just fine for me. Show quoted text On 2016/01/26 00:51:40, stgao wrote: > Does this work? See the conditions 3 and 4 below. > > (https://git-scm.com/docs/gitignore) > > To re-include files or directories when their parent directory is excluded, the > following conditions must be met: > > 1. The rules to exclude a directory and re-include a subset back must be in the > same .gitignore file. > > 2. The directory part in the re-include rules must be literal (i.e. no > wildcards) > > 3. The rules to exclude the parent directory must not end with a trailing slash. > > 4. The rules to exclude the parent directory must have at least one slash. It works just fine for me. chanli 2016/01/27 18:49:54 Done. Show quoted text On 2016/01/26 00:51:40, stgao wrote: > As this is not relative to the main purpose of this CL, maybe create a separate > CL for it? Done. chanli 2016/01/27 18:49:55 Because I have some local scripts in util_scripts/ Show quoted text On 2016/01/26 00:51:40, stgao wrote: > This comment might be misleading, as we need to track more than run.sh Because I have some local scripts in util_scripts/ , I need to have these changes so git won't complain about those scripts. chanli 2016/01/28 17:55:59 Moved to another CL. Show quoted text On 2016/01/27 18:49:55, chanli wrote: > On 2016/01/26 00:51:40, stgao wrote: > > This comment might be misleading, as we need to track more than run.sh > > Because I have some local scripts in util_scripts/ , I need to have these > changes so git won't complain about those scripts. Moved to another CL.
	8 !util_scripts/run.sh

	9 !util_scripts/remote_api.py

	10 !util_scripts/sample_remote_api_query.py

OLD	NEW

« no previous file with comments | « no previous file | appengine/findit/model/test/wf_try_job_test.py » ('j') | appengine/findit/model/test/wf_try_job_test.py » ('J')