[Findit] Modify tryjob pipelines to trigger try jobs for test failure.

appengine/findit/waterfall/schedule_try_job_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from common import buildbucket_client
 from model.wf_try_job import WfTryJob
 from pipeline_wrapper import BasePipeline
 from pipeline_wrapper import pipeline
 from waterfall import waterfall_config
 
 
 class ScheduleTryJobPipeline(BasePipeline):
   """A pipeline for scheduling a new tryjob for current build."""
 
-  def _getBuildProperties(self, recipe, master_name, builder_name,
-                          good_revision, bad_revision, compile_targets):
-
+  def _getBuildProperties(
+      self, master_name, builder_name, good_revision, bad_revision,
+      try_job_type, compile_targets, targeted_tests):
     properties = {
-        'recipe': recipe,
+        'recipe': 'findit/chromium/%s' % try_job_type,
         'good_revision': good_revision,
         'bad_revision': bad_revision,
-        'target_mastername': master_name,
-        'target_buildername': builder_name
+        'target_mastername': master_name
     }
 
+    if try_job_type == 'compile':
+      properties['target_buildername'] = builder_name
+    else:
+      properties['target_testername'] = builder_name
+
+
     if compile_targets:

[lijeffrey, 2016/01/16 00:27:12]

maybe move |if compile_targets| into the try_job_type == 'compile' branch and
|if targeted_tests| into the else branch?

I'd also add a comment for the else branch that all failures that are not
compile are assumed to be test failures

[chanli, 2016/01/20 18:28:04]

Done.

       properties['compile_targets'] = compile_targets
 
+    if targeted_tests:
+      properties['tests'] = targeted_tests
+
     return properties
 
   # Arguments number differs from overridden method - pylint: disable=W0221
   def run(
       self, master_name, builder_name, build_number,
-      good_revision, bad_revision, compile_targets):
+      good_revision, bad_revision, try_job_type,
+      compile_targets=None, targeted_tests=None):
     tryserver_mastername, tryserver_buildername = (
         waterfall_config.GetTrybotForWaterfallBuilder(
             master_name, builder_name))
 
-    recipe = 'findit/chromium/compile'
     properties = self._getBuildProperties(
-        recipe, master_name, builder_name, good_revision, bad_revision,
-        compile_targets)
+        master_name, builder_name, good_revision, bad_revision,
+        try_job_type, compile_targets, targeted_tests)
 
     try_job = buildbucket_client.TryJob(
         tryserver_mastername, tryserver_buildername, None, properties, [])
     error, build = buildbucket_client.TriggerTryJobs([try_job])[0]
 
     if error:  # pragma: no cover
       raise pipeline.Retry(
           'Error "%s" occurred. Reason: "%s"' % (error.message, error.reason))
 
     try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
-    try_job_result.compile_results.append({'try_job_id': build.id})
+    if try_job_type == 'compile':
+      try_job_result.compile_results.append({'try_job_id': build.id})
+    else:
+      try_job_result.test_results.append({'try_job_id': build.id})
     try_job_result.put()
 
     return build.id