Issue 1590983003: Make //sandbox/* pass gn check (and make it gn checked).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1590983003: Make //sandbox/* pass gn check (and make it gn checked). (Closed)

Created:
4 years, 11 months ago by viettrungluu

Modified:
4 years, 11 months ago

Reviewers:
kulakowski

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	sandbox/linux/BUILD.gn	View		8 chunks	+13 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

viettrungluu

4 years, 11 months ago (2016-01-15 21:31:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d5988acc6b06e12b88d72030d2a211da48e25533 (presubmit successful).