Issue 159085: Re-enable extensions auto-update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159085: Re-enable extensions auto-update. (Closed)

Created:
11 years, 5 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Re-enable extensions auto-update. BUG=12117 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21107

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/profile.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

11 years, 5 months ago (2009-07-20 20:23:20 UTC) #2

LGTM

On Mon, Jul 20, 2009 at 1:02 PM, <asargent@chromium.org> wrote:

> Reviewers: Erik Kay,
>
> Description:
> Re-enable extensions auto-update.
>
> BUG=12117
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/159085
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/profile.cc
>
>
> Index: chrome/browser/profile.cc
> ===================================================================
> --- chrome/browser/profile.cc   (revision 21078)
> +++ chrome/browser/profile.cc   (working copy)
> @@ -560,7 +560,7 @@
>       GetPath().AppendASCII(ExtensionsService::kInstallDirectoryName),
>       MessageLoop::current(),
>       g_browser_process->file_thread()->message_loop(),
> -      false);
> +      true);
>
>   extensions_service_->Init();
>
>
>
>

Expand Messages | Collapse Messages