Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1590843003: add SkNx::abs(), for now only implemented for Sk4f (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add SkNx::abs(), for now only implemented for Sk4f There's no reason we couldn't implement this for all ints and floats; just don't want to land unused code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1590843003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/c33065a93ad0874672c4c66b9711aa0b3ef7b7e7

Patch Set 1 #

Patch Set 2 : less anal test #

Patch Set 3 : SkTAbs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/core/SkNx.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/SkNxTest.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590843003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590843003/40001
4 years, 11 months ago (2016-01-15 17:21:04 UTC) #3
mtklein_C
4 years, 11 months ago (2016-01-15 17:26:44 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 17:32:04 UTC) #7
caryclark
lgtm
4 years, 11 months ago (2016-01-15 20:04:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590843003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590843003/40001
4 years, 11 months ago (2016-01-15 20:16:05 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 20:16:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c33065a93ad0874672c4c66b9711aa0b3ef7b7e7

Powered by Google App Engine
This is Rietveld 408576698