Fixing potential memory leak in BookmarkCodec::DecodeNode....

Fixing potential memory leak in BookmarkCodec::DecodeNode.

Coverity finds a condition where this leaks. We are at the moment not using it in such a way that it leaks, but that might of course change. It looks to me like the API is not intended to be used in such a way anyway, so we can just check for it and return false.

BUG=15350
TEST=Decoding bookmarks should work as before.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22379

[Finnur, 2009-07-20 15:16:32]

Bit of a blind fix. Look at it with suspicious eyes. :)

[Finnur, 2009-07-22 00:27:34]

Scott is out this week. Munjal, can you review in his absense?

On 2009/07/20 15:16:32, Finnur wrote:
> Bit of a blind fix. Look at it with suspicious eyes. :)

[sky, 2009-07-30 16:12:02]

I think this should be a DCHECK rather than an if.

   -Scott

On 2009/07/22 00:27:34, Finnur wrote:
> Scott is out this week. Munjal, can you review in his absense?
> 
> On 2009/07/20 15:16:32, Finnur wrote:
> > Bit of a blind fix. Look at it with suspicious eyes. :)

[Finnur, 2009-08-01 13:37:05]

How about adding a NOTREACHED inside the if to make both you and Coverity happy?
:)

(see updated CL) 

On 2009/07/30 16:12:02, sky wrote:
> I think this should be a DCHECK rather than an if.
> 
>    -Scott
> 
> On 2009/07/22 00:27:34, Finnur wrote:
> > Scott is out this week. Munjal, can you review in his absense?
> > 
> > On 2009/07/20 15:16:32, Finnur wrote:
> > > Bit of a blind fix. Look at it with suspicious eyes. :)

[sky, 2009-08-03 15:02:05]

LGTM