Host-side implementation of ARC Intent handler

components/arc/intent_helper/arc_intent_helper_bridge.h

Index: components/arc/intent_helper/arc_intent_helper_bridge.h
diff --git a/components/arc/intent_helper/arc_intent_helper_bridge.h b/components/arc/intent_helper/arc_intent_helper_bridge.h
new file mode 100644
index 0000000000000000000000000000000000000000..5d9729d428a610fb706341deb97264173e9ee6fe
--- /dev/null
+++ b/components/arc/intent_helper/arc_intent_helper_bridge.h
@@ -0,0 +1,26 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_ARC_HELPER_ARC_HELPER_BRIDGE_H_
+#define COMPONENTS_ARC_HELPER_ARC_HELPER_BRIDGE_H_
+
+namespace arc {
+
+// We want ArcServiceManager to own the ArcIntentHelperBridge but
+// ArcIntentHelperBridge depends on code in chrome/ which is not accessible from
+// components/.  Since ArcIntentHelperBridge interacts with the bridge through
+// the global Get function, session manager only needs to see a limited
+// interface. Full implementation at
+// chrome/browser/chromeos/arc/arc_intent_helper_bridge_impl.h
+class ArcIntentHelperBridge {

[Luis Héctor Chávez, 2016/01/15 17:26:47]

This is the third time this exact interface has been introduced, and the
constructor for the ArcServiceManager is getting out of hand.

How about you add

components/arc/arc_service.h:

namespace arc {

class ArcService {
 public:
  virtual ~ArcService() {}
  virtual void Initialize(ArcBridgeService* service) = 0;

 private:
  DISALLOW_COPY_AND_ASSIGN(ArcService);
};

}  // namespace

And make ArcServiceManager receive a std::initializer_list<ArcService>[1] and
store that to a std::vector<ArcService> instead of having to modify that class
every time we want to add a new service. The rest of the services constructed in
the ArcServiceManager can also be modified to implement this interface (except
|arc_notification_manager_|), but that can be done in a separate change.

1: I *think* this should work with std::vector::emplace{_,back}, but if you run
into any issues, fall back to a std::initializer_list<scoped_ptr<ArcService>>.

[Luis Héctor Chávez, 2016/01/15 19:10:22]

That won't work, since std::initializer_list always makes a copy :( Let me think
this again.

[Yusuke Sato, 2016/01/16 00:11:07]

Will rebase this on top of your refactoring CL as needed.

+ public:
+  virtual ~ArcIntentHelperBridge() = 0;

[hidehiko, 2016/01/15 09:04:55]

s/ = 0//

[Yusuke Sato, 2016/01/16 00:11:07]

Done. Is there a standard coding guideline for this? (I followed
components/arc/settings/arc_settings_bridge.h.)

+
+  // Starts listening to state changes of the ArcBridgeService.
+  virtual void StartObservingBridgeServiceChanges() = 0;
+};
+
+}  // namespace arc
+
+#endif  // COMPONENTS_ARC_HELPER_ARC_HELPER_BRIDGE_H_