components/arc/common/intent.mojom - Issue 1590723003: Host-side implementation of ARC Intent handler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/common/intent.mojom

Issue 1590723003: Host-side implementation of ARC Intent handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/arc/common/arc_bridge.mojom ('K') | « components/arc/common/arc_bridge.mojom ('k') | components/arc/intent_helper/arc_intent_helper_bridge.h » ('j') | components/arc/intent_helper/arc_intent_helper_bridge.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module arc;	5 module arc;

6	6

7 interface VideoHost {	7 interface IntentHelperHost {
	Luis Héctor Chávez 2016/01/15 17:26:47 Also document the purpose of this interface. Now Also document the purpose of this interface. Now that I think of it, the Settings interface just sends broadcast intents that are listened by ArcSettings package. Given that it makes more sense for the IntentHelper to also handle broadcast intents, can you sync up with benhansen@ to see if it is possible to drop the settings interface and have the IntentHelperInstance also handle broadcasting intents? Yusuke Sato 2016/01/16 00:11:07 Done. Show quoted text On 2016/01/15 17:26:47, Luis Héctor Chávez wrote: > Also document the purpose of this interface. Done. Show quoted text > Now that I think of it, the Settings interface just sends broadcast intents that > are listened by ArcSettings package. > > Given that it makes more sense for the IntentHelper to also handle broadcast > intents, can you sync up with benhansen@ to see if it is possible to drop the > settings interface and have the IntentHelperInstance also handle broadcasting > intents? Chatted with Ben and we agreed to merge settings.mojom into mine. Let me do that in a separate CL (I'm going to work on that right after this CL.) For now, added a TODO. Ben also told me that LaunchApp() in app.mojom might be a candidate to move to intent.mojo, but the interface can probably stay in app.mojom because LaunchApp does not send intent/broadcast at all. It just issues a binder call to our home screen app.
8 // Notifies Chrome a request for ipc channel of video acceleration.	8 OnOpenUrl@0(string url);
	hidehiko 2016/01/15 09:04:55 Could you document what this does? Could you document what this does? Yusuke Sato 2016/01/16 00:11:07 Done. Show quoted text On 2016/01/15 09:04:55, hidehiko wrote: > Could you document what this does? Done.
9 OnRequestArcVideoAcceleratorChannel() => (handle channel_handle);

10 };	9 };

11	10

12 interface VideoInstance {	11 interface IntentHelperInstance {

13 // Establishes full-duplex communication with the host.	12 // Establishes full-duplex communication with the host.

14 Init(VideoHost host_ptr);	13 Init@0(IntentHelperHost host_ptr);

15 };	14 };

OLD	NEW