Make SkDrawCommands lighter weight

There are two main reasons for this change:

1) captured _canvas_ skps tend to have a lot more drawBitmap* commands then web page skps and, as is, the current system often runs out of memory

2) this should speed up the filter tool when testing out potential optimizations

Note: this CL also extends debug rendering to ovals, round rects, paints and points.

[jvanverth1, 2013-06-05 21:48:02]

A couple of questions:

https://codereview.chromium.org/15907023/diff/2001/debugger/QT/SkImageWidget.cpp
File debugger/QT/SkImageWidget.cpp (right):

https://codereview.chromium.org/15907023/diff/2001/debugger/QT/SkImageWidget....
debugger/QT/SkImageWidget.cpp:18: 
Why not declare fPixels as char fPixels[4*kImageWidgetWidth*kImageWidgetHeight]?
Then you don't need to delete it in the destructor.

https://codereview.chromium.org/15907023/diff/2001/debugger/SkDrawCommand.cpp
File debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/15907023/diff/2001/debugger/SkDrawCommand.cpp...
debugger/SkDrawCommand.cpp:154: 
Why not put the body of this in DrawRRect::render like DrawOval::render and
DrawPoints::render? Is it used somewhere else that I'm not seeing?

[robertphillips, 2013-06-05 22:00:12]

https://codereview.chromium.org/15907023/diff/2001/debugger/QT/SkImageWidget.cpp
File debugger/QT/SkImageWidget.cpp (right):

https://codereview.chromium.org/15907023/diff/2001/debugger/QT/SkImageWidget....
debugger/QT/SkImageWidget.cpp:18: 
On 2013/06/05 21:48:02, JimVV wrote:
> Why not declare fPixels as char
fPixels[4*kImageWidgetWidth*kImageWidgetHeight]?
> Then you don't need to delete it in the destructor.

Done.

https://codereview.chromium.org/15907023/diff/2001/debugger/SkDrawCommand.cpp
File debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/15907023/diff/2001/debugger/SkDrawCommand.cpp...
debugger/SkDrawCommand.cpp:154: 
It is used for both drawRRect and clipRRect.

[djsollen, 2013-06-06 21:17:00]

lgtm with one nit

https://codereview.chromium.org/15907023/diff/8001/debugger/SkDrawCommand.cpp
File debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/15907023/diff/8001/debugger/SkDrawCommand.cpp...
debugger/SkDrawCommand.cpp:97:
canvas->scale(SkDoubleToScalar((0.9*size.fWidth)/bounds.width()),
make this a variable

[robertphillips, 2013-06-07 00:00:17]

committed as r9470

https://codereview.chromium.org/15907023/diff/8001/debugger/SkDrawCommand.cpp
File debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/15907023/diff/8001/debugger/SkDrawCommand.cpp...
debugger/SkDrawCommand.cpp:97:
canvas->scale(SkDoubleToScalar((0.9*size.fWidth)/bounds.width()),
On 2013/06/06 21:17:00, djsollen wrote:
> make this a variable

Done.