Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: content/browser/speech/speech_recognition_manager_impl.cc

Issue 15907012: Implement SpeechRecognizerImplAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Convert error codes in Java, refactor *{,JNI} methods into single methods, nits Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/speech/speech_recognition_manager_impl.cc
diff --git a/content/browser/speech/speech_recognition_manager_impl.cc b/content/browser/speech/speech_recognition_manager_impl.cc
index 33cf503f535fde2b7628867f56f4afc8887e4121..b2014168db35d9fe7161634dc7040ee45cb98e97 100644
--- a/content/browser/speech/speech_recognition_manager_impl.cc
+++ b/content/browser/speech/speech_recognition_manager_impl.cc
@@ -12,6 +12,7 @@
#include "content/browser/speech/google_streaming_remote_engine.h"
#include "content/browser/speech/speech_recognition_engine.h"
#include "content/browser/speech/speech_recognizer_impl.h"
+#include "content/browser/speech/speech_recognizer_impl_android.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/resource_context.h"
@@ -141,10 +142,9 @@ int SpeechRecognitionManagerImpl::CreateSession(
!config.continuous,
google_remote_engine);
#else
- // TODO(janx): Implement a SpeechRecognizerImplAndroid with a JNI interface
- // forwarding calls to Android's platform speech recognition service (see
- // crbug.com/222352).
- session->recognizer = NULL;
+ session->recognizer = new SpeechRecognizerImplAndroid(
bulach 2013/06/11 07:24:48 uber nit: fits one line?
janx 2013/06/12 14:47:14 Fits.
+ this,
+ session_id);
#endif
return session_id;
}

Powered by Google App Engine
This is Rietveld 408576698