Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3448)

Unified Diff: chrome/renderer/searchbox/searchbox.h

Issue 15907006: Rip out browser-side RID caching for most visited items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/searchbox/searchbox.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox.h
diff --git a/chrome/renderer/searchbox/searchbox.h b/chrome/renderer/searchbox/searchbox.h
index 21ff06514b23a108fb015f6aae5e46938251b704..49c31ebacd2b68eb7e5e77c3df618f41811560a4 100644
--- a/chrome/renderer/searchbox/searchbox.h
+++ b/chrome/renderer/searchbox/searchbox.h
@@ -114,6 +114,26 @@ class SearchBox : public content::RenderViewObserver,
// browser.
void UndoAllMostVisitedDeletions();
+ // Generates the thumbnail URL of the most visited item specified by the
+ // |transient_url|. If the |transient_url| is valid, returns true and fills in
+ // |url|. If the |transient_url| is invalid, returns false and |url| is not
+ // set.
+ //
+ // Valid form of |transient_url|:
+ // chrome-search://thumb/<render_view_id>/<most_visited_item_id>
+ bool GenerateThumbnailURLFromTransientURL(const GURL& transient_url,
+ GURL* url) const;
+
+ // Generates the favicon URL of the most visited item specified by the
+ // |transient_url|. If the |transient_url| is valid, returns true and fills in
+ // |url|. If the |transient_url| is invalid, returns false and |url| is not
+ // set.
+ //
+ // Valid form of |transient_url|:
+ // chrome-search://favicon/<render_view_id>/<most_visited_item_id>
+ bool GenerateFaviconURLFromTransientURL(const GURL& transient_url,
+ GURL* url) const;
+
private:
// Overridden from content::RenderViewObserver:
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
@@ -144,7 +164,7 @@ class SearchBox : public content::RenderViewObserver,
void OnFontInformationReceived(const string16& omnibox_font,
size_t omnibox_font_size);
void OnMostVisitedChanged(
- const std::vector<InstantMostVisitedItemIDPair>& items);
+ const std::vector<InstantMostVisitedItem>& items);
void OnToggleVoiceSearch();
// Returns the current zoom factor of the render view or 1 on failure.
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/searchbox/searchbox.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698