chrome/browser/ui/search/search_tab_helper.cc - Issue 15907006: Rip out browser-side RID caching for most visited items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 15907006: Rip out browser-side RID caching for most visited items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index 5086f81134839ebe362d9dfa161dbb4a6af203d6..f84abbe21c027d19f891a5be143590ff03eeace2 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -75,6 +75,15 @@ void SearchTabHelper::NavigationEntryUpdated() {

UpdateMode();

}

+bool SearchTabHelper::UpdateLastKnownMostVisitedItems(

+ const std::vector<InstantMostVisitedItem>& items) {

+ if (chrome::AreMostVisitedItemsEqual(items, last_known_most_visited_items_))

+ return false;

+ last_known_most_visited_items_ = items;

+ return true;

void SearchTabHelper::Observe(

int type,

const content::NotificationSource& source,