Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3360)

Unified Diff: chrome/browser/ui/search/instant_controller.cc

Issue 15907006: Rip out browser-side RID caching for most visited items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/search.cc ('k') | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_controller.cc
diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc
index 4e93098c8159609813a97484c9d36e70bb7ed90e..fe8aae91170d476f36a19eb7d753faebbf1b1dbc 100644
--- a/chrome/browser/ui/search/instant_controller.cc
+++ b/chrome/browser/ui/search/instant_controller.cc
@@ -1122,15 +1122,26 @@ void InstantController::UpdateMostVisitedItems() {
if (!instant_service)
return;
- std::vector<InstantMostVisitedItemIDPair> items;
+ std::vector<InstantMostVisitedItem> items;
instant_service->GetCurrentMostVisitedItems(&items);
- if (overlay_)
+ if (overlay_ && GetOverlayContents() &&
+ SearchTabHelper::FromWebContents(overlay_->contents())->
+ UpdateLastKnownMostVisitedItems(items)) {
overlay_->SendMostVisitedItems(items);
- if (ntp_)
+ }
+
+ if (ntp_ && ntp_->contents() &&
+ SearchTabHelper::FromWebContents(ntp_->contents())->
+ UpdateLastKnownMostVisitedItems(items)) {
ntp_->SendMostVisitedItems(items);
- if (instant_tab_)
+ }
+
+ if (instant_tab_ && instant_tab_->contents() &&
+ SearchTabHelper::FromWebContents(instant_tab_->contents())->
+ UpdateLastKnownMostVisitedItems(items)) {
instant_tab_->SendMostVisitedItems(items);
+ }
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_INSTANT_SENT_MOST_VISITED_ITEMS,
« no previous file with comments | « chrome/browser/search/search.cc ('k') | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698