Adds proper 44.1 support to WebRTC

Adds proper 44.1 support to WebRTC.

This CL removes the existing "WebRTC hack" where the native audio layer runs at 44.1 but WebRTC at 44.0. Now when native WebRTC supports 44100, it is possible to add the same support to WebRTC in Chrome.

BUG=243450
TEST=content_unittests and misc. WebRTC clients using 44.1 as sample rate on input and output devices.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202713

[henrika (OOO until Aug 14), 2013-05-28 12:25:39]

Shijing,

please check. Thanks.

[no longer working on chromium, 2013-05-28 12:33:41]

On 2013/05/28 12:25:39, henrika wrote:
> Shijing,
> 
> please check. Thanks.

lgtm if it works on Android.

[ajm, 2013-05-28 15:13:05]

+wjia

Wei, you've been looking at sample rates on Android recently. Would it be
possible for you to patch and test that this works fine?

https://codereview.chromium.org/15907005/diff/1/content/renderer/media/webrtc...
File content/renderer/media/webrtc_audio_renderer.cc (left):

https://codereview.chromium.org/15907005/diff/1/content/renderer/media/webrtc...
content/renderer/media/webrtc_audio_renderer.cc:156: if (sample_rate % 8000 ==
0) {
Since webrtc needs 10 ms buffers it only supports sample rates divisible by 100
(e.g. not 22050 or 11025 Hz). Should you still have a check on that here?

[henrika (OOO until Aug 14), 2013-05-28 16:40:30]

https://codereview.chromium.org/15907005/diff/1/content/renderer/media/webrtc...
File content/renderer/media/webrtc_audio_renderer.cc (left):

https://codereview.chromium.org/15907005/diff/1/content/renderer/media/webrtc...
content/renderer/media/webrtc_audio_renderer.cc:156: if (sample_rate % 8000 ==
0) {
You will catch that in the lines above where we ensure that the sample rate is
among the supported rates. I.e., you will never end up here using e.g. 11025.

Sound OK?

[ajm, 2013-05-28 16:43:22]

lgtm with Wei's verification.

https://codereview.chromium.org/15907005/diff/1/content/renderer/media/webrtc...
File content/renderer/media/webrtc_audio_renderer.cc (left):

https://codereview.chromium.org/15907005/diff/1/content/renderer/media/webrtc...
content/renderer/media/webrtc_audio_renderer.cc:156: if (sample_rate % 8000 ==
0) {
On 2013/05/28 16:40:30, henrika wrote:
> You will catch that in the lines above where we ensure that the sample rate is
> among the supported rates. I.e., you will never end up here using e.g. 11025.
> 
> Sound OK?

Sounds good, thanks.

[wjia(left Chromium), 2013-05-28 18:46:54]

On 2013/05/28 16:43:22, ajm wrote:
> lgtm with Wei's verification.

Based on my test on Android, the patch doesn't make difference.

> 
>
https://codereview.chromium.org/15907005/diff/1/content/renderer/media/webrtc...
> File content/renderer/media/webrtc_audio_renderer.cc (left):
> 
>
https://codereview.chromium.org/15907005/diff/1/content/renderer/media/webrtc...
> content/renderer/media/webrtc_audio_renderer.cc:156: if (sample_rate % 8000 ==
> 0) {
> On 2013/05/28 16:40:30, henrika wrote:
> > You will catch that in the lines above where we ensure that the sample rate
is
> > among the supported rates. I.e., you will never end up here using e.g.
11025.
> > 
> > Sound OK?
> 
> Sounds good, thanks.

[ajm, 2013-05-28 18:54:34]

On 2013/05/28 18:46:54, wjia wrote:
> On 2013/05/28 16:43:22, ajm wrote:
> > lgtm with Wei's verification.
> 
> Based on my test on Android, the patch doesn't make difference.

Great. Ship it.

[no longer working on chromium, 2013-05-28 19:03:47]

Just to double check, this patch will only affect the case when browser is using
44100 as sample rate. Wei, could you please confirm that
GetNativeOutputSampleRate() returns 44100 in your test case?

[wjia(left Chromium), 2013-05-28 19:06:05]

I tested it on Galaxy Nexus which returns 44100Hz for both input and output.


On Tue, May 28, 2013 at 12:03 PM, <xians@chromium.org> wrote:

>
> Just to double check, this patch will only affect the case when browser is
> using
> 44100 as sample rate. Wei, could you please confirm that
> GetNativeOutputSampleRate() returns 44100 in your test case?
>
>
>
>
https://codereview.chromium.**org/15907005/<https://codereview.chromium.org/1...
>

[no longer working on chromium, 2013-05-28 19:10:19]

Great.



On Tue, May 28, 2013 at 9:06 PM, Wei Jia <wjia@chromium.org> wrote:

> I tested it on Galaxy Nexus which returns 44100Hz for both input and
> output.
>
>
> On Tue, May 28, 2013 at 12:03 PM, <xians@chromium.org> wrote:
>
>>
>> Just to double check, this patch will only affect the case when browser
>> is using
>> 44100 as sample rate. Wei, could you please confirm that
>> GetNativeOutputSampleRate() returns 44100 in your test case?
>>
>>
>>
>>
https://codereview.chromium.**org/15907005/<https://codereview.chromium.org/1...
>>
>
>

[commit-bot: I haz the power, 2013-05-28 20:21:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/15907005/1

[commit-bot: I haz the power, 2013-05-28 20:22:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/15907005/1

[commit-bot: I haz the power, 2013-05-29 00:37:17]

Change committed as 202713