Reflecting the changes on bookmarks in History page....

chrome/browser/dom_ui/history_ui.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/history_ui.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/message_loop.h"
 #include "base/string_piece.h"
@@ skipping 99 matching lines @@
 DOMMessageHandler* BrowsingHistoryHandler::Attach(DOMUI* dom_ui) {
   // Create our favicon data source.
   g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE,
       NewRunnableMethod(&chrome_url_data_manager,
       &ChromeURLDataManager::AddDataSource,
       new DOMUIFavIconSource(dom_ui->GetProfile())));
 
   // Get notifications when history is cleared.
   registrar_.Add(this, NotificationType::HISTORY_URLS_DELETED,
       Source<Profile>(dom_ui->GetProfile()->GetOriginalProfile()));
+  registrar_.Add(this, NotificationType::URLS_STARRED,
+      Source<Profile>(dom_ui->GetProfile()->GetOriginalProfile()));
   return DOMMessageHandler::Attach(dom_ui);
 }
 
 void BrowsingHistoryHandler::RegisterMessages() {
   dom_ui_->RegisterMessageCallback("getHistory",
       NewCallback(this, &BrowsingHistoryHandler::HandleGetHistory));
   dom_ui_->RegisterMessageCallback("searchHistory",
       NewCallback(this, &BrowsingHistoryHandler::HandleSearchHistory));
   dom_ui_->RegisterMessageCallback("deleteDay",
       NewCallback(this, &BrowsingHistoryHandler::HandleDeleteDay));
@@ skipping 208 matching lines @@
     }
     options.begin_time = base::Time::FromLocalExploded(exploded);
   }
 
   return options;
 }
 
 void BrowsingHistoryHandler::Observe(NotificationType type,
                                      const NotificationSource& source,
                                      const NotificationDetails& details) {
-  if (type != NotificationType::HISTORY_URLS_DELETED) {
-    NOTREACHED();
-    return;
+  if (type == NotificationType::HISTORY_URLS_DELETED) {
+    // Some URLs were deleted from history. Reload the list.
+    dom_ui_->CallJavascriptFunction(L"historyDeleted");
+  } else if (type == NotificationType::URLS_STARRED) {
+    // Maybe some bookmarks were added, removed, moved or favicon changed.
+    dom_ui_->CallJavascriptFunction(L"reloadList");

[Glen Murphy, 2009/07/30 17:18:28]

I don't think you want to make it reload the page - this will cause the view to
reset to default, which you don't want if you're on anything other than the
first page. The reason we do it for deletions is that large chunks tend to get
deleted at a time, invalidating the page you're looking at.

I think you need to figure out what URLs were starred, send those URLs to the
page, then get it to update the individual items accordingly. This is
significantly harder, and is why we didn't do it in the first place.

   }
-
-  // Some URLs were deleted from history. Reload the list.
-  dom_ui_->CallJavascriptFunction(L"historyDeleted");
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // HistoryUIContents
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 HistoryUI::HistoryUI(TabContents* contents) : DOMUI(contents) {
   AddMessageHandler((new BrowsingHistoryHandler())->Attach(this));
 
   HistoryUIHTMLSource* html_source = new HistoryUIHTMLSource();
 
   // Set up the chrome://history/ source.
   g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE,
       NewRunnableMethod(&chrome_url_data_manager,
           &ChromeURLDataManager::AddDataSource,
           html_source));
 }
 
 // static
 const GURL HistoryUI::GetHistoryURLWithSearchText(const std::wstring& text) {
   return GURL(std::string(chrome::kChromeUIHistoryURL) + "#q=" +
               EscapeQueryParamValue(WideToUTF8(text)));
 }
+