Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1590673002: Separate String.prototype.replace into RegExp.prototype[Symbol.replace] (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Separate String.prototype.replace into RegExp.prototype[Symbol.replace] This patch implements one aspect of ES2015 RegExp subclassing: String.prototype.replace is separated into two parts, a method on RegExp.prototype in case the first argument is a RegExp, and the String.prototype.replace method, which handles the string pattern case. This separation is described in the ES2015 specification. Most of the patch is simply moving code from string.js to regexp.js. R=yangguo LOG=Y BUG=v8:4343 Committed: https://crrev.com/837e374eace4b325ca93fb00b73568642f16f612 Cr-Commit-Position: refs/heads/master@{#33393}

Patch Set 1 #

Patch Set 2 : Remove extra newline from test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -163 lines) Patch
M src/js/regexp.js View 5 chunks +173 lines, -0 lines 0 comments Download
M src/js/string.js View 6 chunks +10 lines, -163 lines 0 comments Download
A test/mjsunit/harmony/string-replace.js View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590673002/1
4 years, 11 months ago (2016-01-14 22:43:40 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9796)
4 years, 11 months ago (2016-01-14 22:45:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590673002/20001
4 years, 11 months ago (2016-01-14 22:49:44 UTC) #6
Dan Ehrenberg
4 years, 11 months ago (2016-01-14 23:03:17 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 23:12:45 UTC) #9
Yang
On 2016/01/14 23:12:45, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2016-01-19 13:19:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590673002/20001
4 years, 11 months ago (2016-01-19 17:11:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-19 17:33:28 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 17:33:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/837e374eace4b325ca93fb00b73568642f16f612
Cr-Commit-Position: refs/heads/master@{#33393}

Powered by Google App Engine
This is Rietveld 408576698