Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1590583002: Expose worklet on Window through attribute renderWorklet. (Closed)

Created:
4 years, 11 months ago by ikilpatrick
Modified:
4 years, 11 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose worklet on Window through attribute renderWorklet. https://drafts.css-houdini.org/worklets/#dom-window-renderworklet This may change in the future if HoudiniTF decides to split into separate Worklets for each stage. Additionally add kinuko as OWNERS to worklet directory. BUG=567358 Committed: https://crrev.com/709d67b3876a36d7aa2a0a3cd744d6dd5ffb9e59 Cr-Commit-Position: refs/heads/master@{#369778}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -7 lines) Patch
M third_party/WebKit/Source/modules/modules.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/worklet/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/worklet/WindowWorklet.idl View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ikilpatrick
https://codereview.chromium.org/1590583002/diff/20001/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp File third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp (right): https://codereview.chromium.org/1590583002/diff/20001/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp#newcode15 third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp:15: workletGlobalScope->script()->initializeContextIfNeeded(); This was added here as within: V8DOMWrapper::associateObjectWithWrapper (inside ...
4 years, 11 months ago (2016-01-14 19:31:57 UTC) #2
kinuko
lgtm https://codereview.chromium.org/1590583002/diff/20001/third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp File third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp (right): https://codereview.chromium.org/1590583002/diff/20001/third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp#newcode39 third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp:39: return DOMWindowWorklet::from(toLocalDOMWindow(window)).renderWorklet(executionContext); nit: DOMWindowWorklet:: not needed
4 years, 11 months ago (2016-01-15 04:19:34 UTC) #3
ikilpatrick
https://codereview.chromium.org/1590583002/diff/20001/third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp File third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp (right): https://codereview.chromium.org/1590583002/diff/20001/third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp#newcode39 third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp:39: return DOMWindowWorklet::from(toLocalDOMWindow(window)).renderWorklet(executionContext); On 2016/01/15 04:19:34, kinuko wrote: > nit: ...
4 years, 11 months ago (2016-01-15 16:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590583002/40001
4 years, 11 months ago (2016-01-15 16:58:36 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-15 17:25:25 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 17:26:21 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/709d67b3876a36d7aa2a0a3cd744d6dd5ffb9e59
Cr-Commit-Position: refs/heads/master@{#369778}

Powered by Google App Engine
This is Rietveld 408576698