Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1590533003: fix a nondeterministic error messsage by sorting the field names (Closed)

Created:
4 years, 11 months ago by skybrian
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix a nondeterministic error messsage by sorting the field names BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/648e62243c37814c55a7ae4a671ef90247d3d33f

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +7 lines, -8 lines 3 comments Download

Messages

Total messages: 6 (2 generated)
skybrian
4 years, 11 months ago (2016-01-15 01:50:18 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1590533003/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (right): https://codereview.chromium.org/1590533003/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart#newcode1291 pkg/analyzer/lib/src/generated/error_verifier.dart:1291: var names = notInitFinalFields.map((item) => item.name).toList(); In non-test ...
4 years, 11 months ago (2016-01-15 15:26:04 UTC) #3
skybrian
Committed patchset #1 (id:1) manually as 648e62243c37814c55a7ae4a671ef90247d3d33f (presubmit successful).
4 years, 11 months ago (2016-01-15 22:47:03 UTC) #5
skybrian
4 years, 11 months ago (2016-01-15 22:48:06 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1590533003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/1590533003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:1291: var names =
notInitFinalFields.map((item) => item.name).toList();
On 2016/01/15 15:26:04, Brian Wilkerson wrote:
> In non-test code, we type annotate everything.

Done.

https://codereview.chromium.org/1590533003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:1298: } else if
(notInitFinalFields.length == 2) {
changed to names.length

Powered by Google App Engine
This is Rietveld 408576698