Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 1590523004: Revert "dart2js cps: Avoid comparing boolean values to boolean constants." (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js cps: Avoid comparing boolean values to boolean constants." This reverts commit dd8ba75909d2ba36d8cb79b217e00604c942ba02. BUG= Committed: https://github.com/dart-lang/sdk/commit/2680d9ab04045b9b8e79aa6237bc3c35d4a13f21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -56 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +18 lines, -56 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
asgerf
TBR forgot to update units tests
4 years, 11 months ago (2016-01-14 20:55:36 UTC) #2
asgerf
4 years, 11 months ago (2016-01-14 20:55:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2680d9ab04045b9b8e79aa6237bc3c35d4a13f21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698