Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1590513003: [Interpreter] Remove Ignition skips fixed by 48a3227b (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove Ignition skips fixed by 48a3227b Remove ignition skips which are fixed by https://chromium.googlesource.com/v8/v8/+/48a3227b7dd2f285aa599eb1cdf5f8bc94acdec7. BUG=v8:4280 LOG=N Committed: https://crrev.com/be2210bcc48c9723fc9b6a0e00cdab2e401b2906 Cr-Commit-Position: refs/heads/master@{#33322}

Patch Set 1 #

Patch Set 2 : Add back some tests which still fail on Arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 3 chunks +1 line, -14 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590513003/1
4 years, 11 months ago (2016-01-14 21:48:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590513003/20001
4 years, 11 months ago (2016-01-14 22:27:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 22:48:06 UTC) #6
rmcilroy
Jakob, ptal, thanks.
4 years, 11 months ago (2016-01-15 08:51:31 UTC) #8
Jakob Kummerow
lgtm
4 years, 11 months ago (2016-01-15 10:14:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590513003/20001
4 years, 11 months ago (2016-01-15 11:08:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 11:26:15 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 11:26:32 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/be2210bcc48c9723fc9b6a0e00cdab2e401b2906
Cr-Commit-Position: refs/heads/master@{#33322}

Powered by Google App Engine
This is Rietveld 408576698