Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1590473002: Fix git cl upload --squash (for Gerrit). (Closed)

Created:
4 years, 11 months ago by tandrii(chromium)
Modified:
4 years, 11 months ago
Reviewers:
Bernhard Bauer, Bons
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M git_cl.py View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tandrii(chromium)
PTAL without this the os.close fails with invalid handle like: Traceback (most recent call last): ...
4 years, 11 months ago (2016-01-14 14:59:53 UTC) #1
Bernhard Bauer
Ugh. Thanks for this fix! LGTM
4 years, 11 months ago (2016-01-14 15:53:36 UTC) #2
Bons
lgtm
4 years, 11 months ago (2016-01-14 15:58:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590473002/1
4 years, 11 months ago (2016-01-14 15:59:23 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 16:01:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298270

Powered by Google App Engine
This is Rietveld 408576698