Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 15904014: Revert 202866 "Blink roll 151349:151373" (Closed)

Created:
7 years, 6 months ago by dmichael (off chromium)
Modified:
7 years, 6 months ago
Reviewers:
eseidel
CC:
chromium-reviews, Ian Vollick, Tom Hudson, tasak (please_use_google.com)
Visibility:
Public.

Description

Revert 202866 "Blink roll 151349:151373" Caused WebViewInteractiveTest.PopupPositioningMoved to fail on Mac dbg 10.6 and 10.7: WebViewInteractiveTest.PopupPositioningMoved: [1326:263:0529/075351:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context. /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /Volumes/data/b/build/third_party/twisted_10_2/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /Volumes/data/b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources HTTP server started on 127.0.0.1:49950... sending server_data: {"host": "127.0.0.1", "port": 49950} (36 bytes) [1325:263:0529/075353:219402889538:INFO:CONSOLE(431)] "chrome.webRequest is not available: You do not have permission to access this API. Ensure that the required permission or manifest property is included in your manifest.json.", source: binding (431) [1325:263:0529/075353:220201666944:INFO:CONSOLE(431)] "chrome.webRequest is not available: You do not have permission to access this API. Ensure that the required permission or manifest property is included in your manifest.json.", source: binding (431) [1326:263:0529/075354:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context. [1326:263:0529/075355:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context. [1326:263:0529/075355:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context. [1325:263:0529/075356:222219659574:INFO:CONSOLE(18)] "webview.loadstop", source: chrome-extension://nnkmmcedebpphammhapimbckejdabddg/main.js (18) [1325:263:0529/075356:222325071892:INFO:CONSOLE(33)] "onInput, value: C, step = 1", source: http://localhost:49950/files/extensions/platform_apps/web_view/popup_positioning_moved/guest.html (33) [1325:263:0529/075356:222831052658:INFO:web_view_interactive_browsertest.cc(227)] DIFF: x = 42, y = 86 ../../chrome/browser/extensions/web_view_interactive_browsertest.cc:237: Failure Expected: (std::abs(diff.x() - left_spacing)) <= (threshold_px), actual: 18 vs 10 [1325:263:0529/075356:222837065116:INFO:CONSOLE(33)] "onInput, value: Chromium, step = 2", source: http://localhost:49950/files/extensions/platform_apps/web_view/popup_positioning_moved/guest.html (33) > Blink roll 151349:151373 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151373&mode=html > TBR= > BUG= > > Review URL: https://chromiumcodereview.appspot.com/16194003 TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dmichael (off chromium)
7 years, 6 months ago (2013-05-29 15:15:44 UTC) #1
dmichael (off chromium)
7 years, 6 months ago (2013-05-29 15:16:32 UTC) #2
dmichael (off chromium)
Committed patchset #1 manually as r202872.
7 years, 6 months ago (2013-05-29 15:17:13 UTC) #3
eseidel
It looks like this is a new failure: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=WebViewInteractiveTest.PopupPositioningMoved Unclear why this isn't caught by ...
7 years, 6 months ago (2013-05-29 19:22:33 UTC) #4
eseidel
Here is a clean run of the interactive_ui_tests: http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/132591/steps/interactive_ui_tests Looks like this didn't fail in ...
7 years, 6 months ago (2013-05-29 19:23:50 UTC) #5
Avi (use Gerrit)
On 2013/05/29 19:23:50, eseidel wrote: > Here is a clean run of the interactive_ui_tests: > ...
7 years, 6 months ago (2013-05-29 19:30:44 UTC) #6
eseidel
It looks like this only fails on mac, and only on debug, is that correct? ...
7 years, 6 months ago (2013-05-29 19:35:45 UTC) #7
eseidel
http://src.chromium.org/viewvc/blink?view=rev&revision=151373 appears to be the only change in that roll which looks even possibly related ...
7 years, 6 months ago (2013-05-29 19:37:12 UTC) #8
eseidel
7 years, 6 months ago (2013-05-29 19:39:01 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/15797008 is the second roll-revert, btw.

Powered by Google App Engine
This is Rietveld 408576698