Fix issue 3874: non-deterministic AST generation caused by exceptions being thrown during parsing (…

runtime/vm/parser.cc

Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc	(revision 23328)
+++ runtime/vm/parser.cc	(working copy)
@@ -8118,6 +8118,10 @@
       if (const_value.IsError()) {
         const Error& error = Error::Cast(const_value);
         if (error.IsUnhandledException()) {
+          // An exception may not occur in every parse attemp, i.e., the

[Florian Schneider, 2013/05/29 12:58:45]

s/attemp/attempt/

[srdjan, 2013/05/29 13:01:29]

Done.

+          // generated AST is not deterministic. Therefore mark the function as
+          // not optimizable.
+          current_function().set_is_optimizable(false);
           field.set_value(Instance::Handle());
           // It is a compile-time error if evaluation of a compile-time constant
           // would raise an exception.
@@ -8181,6 +8185,10 @@
                                                arg_values,
                                                arg_descriptor));
   if (result.IsError()) {
+      // An exception may not occur in every parse attemp, i.e., the

[Florian Schneider, 2013/05/29 12:58:45]

s/attemp/attempt/

[srdjan, 2013/05/29 13:01:29]

Done.

+      // generated AST is not deterministic. Therefore mark the function as
+      // not optimizable.
+      current_function().set_is_optimizable(false);
       if (result.IsUnhandledException()) {
         return result.raw();
       } else {