Only show breakpoints at possible breakpoint positions in Observatory.

Only show breakpoints at possible breakpoint positions in Observatory.

We now use getSourceReport to get an accurate list of possible
breakpoints rather than relying on inaccurate heuristics.  This means,
for example, that variable declarations will stop being labeled
incorrectly as potential breakpoints.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/318db3387569d343fba0d292151fe8dff4cd46fb

[turnidge, 2016-01-15 18:36:36]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-01-15 21:06:02]

LGTM with some questions / comments.

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/script_inset.dart (right):

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:1005: var e = new
DivElement();
Why move the var e = new DivElement() into the branch and then duplicate it
below? The original code just allocates it right away.

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:1038:
line.changes.listen((_) => update);
update()

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1533: return
invokeRpc('addBreakpoint', params);
You're dropping the catch block is that intentional?

[turnidge, 2016-01-15 22:41:39]

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/script_inset.dart (right):

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:1005: var e = new
DivElement();
On 2016/01/15 21:06:02, Cutch wrote:
> Why move the var e = new DivElement() into the branch and then duplicate it
> below? The original code just allocates it right away.

Done.

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:1038:
line.changes.listen((_) => update);
On 2016/01/15 21:06:02, Cutch wrote:
> update()

Done.

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1590353002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1533: return
invokeRpc('addBreakpoint', params);
On 2016/01/15 21:06:02, Cutch wrote:
> You're dropping the catch block is that intentional?

Yes.

[turnidge, 2016-01-15 22:56:38]

Description was changed from

==========
Only show breakpoints at possible breakpoint positions in Observatory.

We now use getSourceReport to get an accurate list of possible
breakpoints rather than relying on inaccurate heuristics.  This means,
for example, that variable declarations will stop being labeled
incorrectly as potential breakpoints.

BUG=
==========

to

==========
Only show breakpoints at possible breakpoint positions in Observatory.

We now use getSourceReport to get an accurate list of possible
breakpoints rather than relying on inaccurate heuristics.  This means,
for example, that variable declarations will stop being labeled
incorrectly as potential breakpoints.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/318db3387569d343fba0d292151fe8dff4cd46fb
==========

[turnidge, 2016-01-15 22:56:39]

Committed patchset #4 (id:60001) manually as
318db3387569d343fba0d292151fe8dff4cd46fb (presubmit successful).