Subzero: Make optimizations more resilient for early Target development.

src/IceCfgNode.cpp

 //===- subzero/src/IceCfgNode.cpp - Basic block (node) implementation -----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 834 matching lines @@
     return;
   Inst *Branch = nullptr;
   for (Inst &I : Insts) {
     if (I.isDeleted())
       continue;
     if (I.isUnconditionalBranch())
       Branch = &I;
     else if (!I.isRedundantAssign())
       return;
   }
+  // Make sure there is actually a successor to repoint in-edges to.
+  if (OutEdges.empty())
+    return;
   assert(OutEdges.size() == 1);
   // Don't try to delete a self-loop.
   if (OutEdges[0] == this)
     return;
+  // Make sure the node actually contains (ends with) an unconditional branch.
+  if (Branch == nullptr)
+    return;
 
   Branch->setDeleted();
   CfgNode *Successor = OutEdges.front();
   // Repoint all this node's in-edges to this node's successor, unless this
   // node's successor is actually itself (in which case the statement
   // "OutEdges.front()->InEdges.push_back(Pred)" could invalidate the iterator
   // over this->InEdges).
   if (Successor != this) {
     for (CfgNode *Pred : InEdges) {
       for (CfgNode *&I : Pred->OutEdges) {
@@ skipping 557 matching lines @@
   auto *Inst = InstIntrinsicCall::create(
       Func, 5, Func->makeVariable(IceType_i64), RMWI64Name, Info->Info);
   Inst->addArg(AtomicRMWOp);
   Inst->addArg(Counter);
   Inst->addArg(One);
   Inst->addArg(OrderAcquireRelease);
   Insts.push_front(Inst);
 }
 
 } // end of namespace Ice