Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1590243003: [Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND) (Closed)

Created:
4 years, 11 months ago by jbudorick
Modified:
4 years, 11 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, yfriedman+watch_chromium.org, vmpstr+watch_chromium.org, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND) This is a reland of https://codereview.chromium.org/1581563003 BUG=272790 TBR=thakis@chromium.org,yfriedman@chromium.org,phajdan.jr@chromium.org Committed: https://crrev.com/ab450c5ede0635194331286088d0f488f4086ba5 Cr-Commit-Position: refs/heads/master@{#369815}

Patch Set 1 : original #

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -152 lines) Patch
M base/BUILD.gn View 3 chunks +4 lines, -5 lines 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + base/android/java/src/org/chromium/base/multidex/ChromiumMultiDexInstaller.java View 7 chunks +6 lines, -10 lines 0 comments Download
M base/android/java/templates/ChromiumMultiDex.template View 1 chunk +10 lines, -103 lines 0 comments Download
M base/base.gyp View 4 chunks +10 lines, -4 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/gyp/configure_multidex.py View 2 chunks +41 lines, -9 lines 0 comments Download
M build/android/java_cpp_template.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M build/android/pylib/remote/device/dummy/dummy.gyp View 1 2 chunks +23 lines, -1 line 0 comments Download
M build/apk_browsertest.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/apk_test.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 chunks +19 lines, -2 lines 0 comments Download
M build/java_apk.gypi View 1 5 chunks +41 lines, -10 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 2 chunks +3 lines, -0 lines 0 comments Download
M testing/test.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jbudorick
agrieve: ptal at new changes to build/ thakis, yfriedman, phajdan.jr: tbr because base/, chrome/, and ...
4 years, 11 months ago (2016-01-15 18:05:11 UTC) #4
jbudorick
(forgot to add TBRs to reviewer line)
4 years, 11 months ago (2016-01-15 18:05:42 UTC) #6
agrieve
On 2016/01/15 18:05:42, jbudorick wrote: > (forgot to add TBRs to reviewer line) lgtm. Will ...
4 years, 11 months ago (2016-01-15 18:45:11 UTC) #7
jbudorick
On 2016/01/15 18:45:11, agrieve wrote: > On 2016/01/15 18:05:42, jbudorick wrote: > > (forgot to ...
4 years, 11 months ago (2016-01-15 18:46:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590243003/20001
4 years, 11 months ago (2016-01-15 18:48:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 19:43:55 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ab450c5ede0635194331286088d0f488f4086ba5 Cr-Commit-Position: refs/heads/master@{#369815}
4 years, 11 months ago (2016-01-15 19:45:04 UTC) #13
jbudorick
4 years, 11 months ago (2016-01-15 22:19:57 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1587673014/ by jbudorick@chromium.org.

The reason for reverting is: mysterious compile errors on Android appeared two
builds after this landed.

https://build.chromium.org/p/chromium/builders/Android/builds/50690.

Powered by Google App Engine
This is Rietveld 408576698