Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1590223003: Expose API for gx font variation axes. (Closed)

Created:
4 years, 11 months ago by bungeman-skia
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Work on Mac. #

Patch Set 3 : Comments and whitespace. #

Patch Set 4 : Naming and comments. #

Patch Set 5 : Fix FontConfig and Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -25 lines) Patch
M gm/fontscalerdistortable.cpp View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M include/ports/SkFontMgr.h View 1 2 3 3 chunks +50 lines, -1 line 0 comments Download
M src/core/SkFontMgr.cpp View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 2 3 1 chunk +139 lines, -0 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 2 3 4 4 chunks +42 lines, -21 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590223003/1
4 years, 11 months ago (2016-01-19 16:17:41 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590223003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590223003/40001
4 years, 11 months ago (2016-01-19 19:14:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-19 19:25:38 UTC) #8
bungeman-skia
4 years, 11 months ago (2016-01-19 19:26:54 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590223003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590223003/80001
4 years, 11 months ago (2016-01-21 20:14:06 UTC) #12
bungeman-skia
Updated names and added some comments.
4 years, 11 months ago (2016-01-21 20:15:30 UTC) #13
reed1
lgtm
4 years, 11 months ago (2016-01-21 22:11:25 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 22:16:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590223003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590223003/80001
4 years, 11 months ago (2016-01-21 22:17:01 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 22:17:52 UTC) #22
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f6c7107d0385cc2b556802354b93b7dcff61570d

Powered by Google App Engine
This is Rietveld 408576698