third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl - Issue 1590193002: Partial implementation of inline StylePropertyMap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl

Issue 1590193002: Partial implementation of inline StylePropertyMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maps

Patch Set: Address Tim's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp ('K') | « third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 RuntimeEnabled=CSSTypedOM,	6 RuntimeEnabled=CSSTypedOM,

7 GarbageCollected	7 GarbageCollected

8 ] interface StylePropertyMap {	8 ] interface StylePropertyMap {

9 [RaisesException] void append(DOMString property, (StyleValue or sequence<St yleValue> or DOMString) value);	9 [RaisesException] void append(DOMString property, (StyleValue or sequence<St yleValue> or DOMString)? value);
	Timothy Loh 2016/04/07 03:42:53 Is this changing these to be optional (allow null) Is this changing these to be optional (allow null)? Doesn't seem like the spec has this. meade_UTC10 2016/04/07 05:41:30 Ah, I think I was trying something out. Fixed. Show quoted text On 2016/04/07 03:42:53, Timothy Loh wrote: > Is this changing these to be optional (allow null)? Doesn't seem like the spec > has this. Ah, I think I was trying something out. Fixed.
10 [RaisesException, ImplementedAs=remove] void delete(DOMString property);	10 [RaisesException, ImplementedAs=remove] void delete(DOMString property);

11 StyleValue? get(DOMString property);	11 [RaisesException] StyleValue? get(DOMString property);

12 sequence<StyleValue> getAll(DOMString property);	12 [RaisesException] sequence<StyleValue> getAll(DOMString property);

13 boolean has(DOMString property);	13 [RaisesException] boolean has(DOMString property);

14 [RaisesException] void set(DOMString property, (StyleValue or sequence<Style Value> or DOMString) value);	14 [RaisesException] void set(DOMString property, (StyleValue or sequence<Style Value> or DOMString)? value);

15 iterable<DOMString, (StyleValue or sequence<StyleValue>)>;	15 iterable<DOMString, (StyleValue or sequence<StyleValue>)>;

16 sequence<DOMString> getProperties();	16 sequence<DOMString> getProperties();

17 };	17 };

OLD	NEW