Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1590143002: removeBetween() -> detach() performance fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clear invalidation in Element::removedFrom. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1512 matching lines...) Expand 10 before | Expand all | Expand 10 after
1523 ContainerNode::removedFrom(insertionPoint); 1523 ContainerNode::removedFrom(insertionPoint);
1524 if (wasInDocument) { 1524 if (wasInDocument) {
1525 if (this == document().cssTarget()) 1525 if (this == document().cssTarget())
1526 document().setCSSTarget(nullptr); 1526 document().setCSSTarget(nullptr);
1527 1527
1528 if (hasPendingResources()) 1528 if (hasPendingResources())
1529 document().accessSVGExtensions().removeElementFromPendingResources(t his); 1529 document().accessSVGExtensions().removeElementFromPendingResources(t his);
1530 1530
1531 if (isUpgradedCustomElement()) 1531 if (isUpgradedCustomElement())
1532 CustomElement::didDetach(this, insertionPoint->document()); 1532 CustomElement::didDetach(this, insertionPoint->document());
1533
1534 document().styleEngine().styleInvalidator().clearInvalidation(*this);
esprehn 2016/01/15 17:07:24 Can we do a bit check here to avoid this long chai
rune 2016/01/15 17:22:21 Done.
1533 } 1535 }
1534 1536
1535 document().removeFromTopLayer(this); 1537 document().removeFromTopLayer(this);
1536 1538
1537 clearElementFlag(IsInCanvasSubtree); 1539 clearElementFlag(IsInCanvasSubtree);
1538 1540
1539 if (hasRareData()) { 1541 if (hasRareData()) {
1540 ElementRareData* data = elementRareData(); 1542 ElementRareData* data = elementRareData();
1541 1543
1542 data->clearRestyleFlags(); 1544 data->clearRestyleFlags();
(...skipping 2103 matching lines...) Expand 10 before | Expand all | Expand 10 after
3646 { 3648 {
3647 #if ENABLE(OILPAN) 3649 #if ENABLE(OILPAN)
3648 if (hasRareData()) 3650 if (hasRareData())
3649 visitor->trace(elementRareData()); 3651 visitor->trace(elementRareData());
3650 visitor->trace(m_elementData); 3652 visitor->trace(m_elementData);
3651 #endif 3653 #endif
3652 ContainerNode::trace(visitor); 3654 ContainerNode::trace(visitor);
3653 } 3655 }
3654 3656
3655 } // namespace blink 3657 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698