Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 159013003: Remove extended_extra_ic_state and extend extra_ic_state instead. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Remove extended_extra_ic_state and extend extra_ic_state instead. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19287

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -64 lines) Patch
M src/code-stubs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M src/objects.h View 5 chunks +3 lines, -23 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects-inl.h View 5 chunks +9 lines, -23 lines 1 comment Download
M src/type-info.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-10 16:23:00 UTC) #1
Igor Sheludko
LGTM assuming that this is a first part of upcoming changes. https://codereview.chromium.org/159013003/diff/1/src/objects-inl.h File src/objects-inl.h (right): ...
6 years, 10 months ago (2014-02-11 10:35:27 UTC) #2
Toon Verwaest
6 years, 10 months ago (2014-02-11 15:01:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698