Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 15901019: Add myself and dbeam as OWNERS of the closure_linter and python_gflags third party libraries. (Closed)

Created:
7 years, 6 months ago by Tyler Breisacher (Chromium)
Modified:
7 years, 6 months ago
Reviewers:
brettw, Dan Beam, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add myself and dbeam as OWNERS of the closure_linter and python_gflags third party libraries. TBR=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206276

Patch Set 1 #

Patch Set 2 : note the owners change in the README.chromium files #

Patch Set 3 : tab->space #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --2 lines) Patch
A + third_party/closure_linter/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/closure_linter/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/python_gflags/OWNERS View 0 chunks +-1 lines, --1 lines 1 comment Download
M third_party/python_gflags/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Tyler Breisacher (Chromium)
7 years, 6 months ago (2013-06-11 20:03:04 UTC) #1
Tyler Breisacher (Chromium)
7 years, 6 months ago (2013-06-11 20:04:12 UTC) #2
Dan Beam
https://codereview.chromium.org/15901019/diff/5001/third_party/python_gflags/OWNERS File third_party/python_gflags/OWNERS (right): https://codereview.chromium.org/15901019/diff/5001/third_party/python_gflags/OWNERS#newcode2 third_party/python_gflags/OWNERS:2: tbreisacher@chromium.org do you want to add someone that knows ...
7 years, 6 months ago (2013-06-11 20:53:34 UTC) #3
Tyler Breisacher (Chromium)
7 years, 6 months ago (2013-06-11 21:44:30 UTC) #4
Tyler Breisacher (Chromium)
On 2013/06/11 20:53:34, Dan Beam wrote: > https://codereview.chromium.org/15901019/diff/5001/third_party/python_gflags/OWNERS > File third_party/python_gflags/OWNERS (right): > > https://codereview.chromium.org/15901019/diff/5001/third_party/python_gflags/OWNERS#newcode2 ...
7 years, 6 months ago (2013-06-11 21:44:54 UTC) #5
M-A Ruel
On 2013/06/11 21:44:54, Tyler Breisacher (Chromium) wrote: > On 2013/06/11 20:53:34, Dan Beam wrote: > ...
7 years, 6 months ago (2013-06-11 22:13:49 UTC) #6
tbreisacher
On 2013/06/11 22:13:49, Marc-Antoine Ruel wrote: > On 2013/06/11 21:44:54, Tyler Breisacher (Chromium) wrote: > ...
7 years, 6 months ago (2013-06-11 22:14:39 UTC) #7
Dan Beam
lgtm
7 years, 6 months ago (2013-06-11 22:36:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/15901019/5001
7 years, 6 months ago (2013-06-14 01:41:02 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 02:49:14 UTC) #10
Message was sent while issue was closed.
Change committed as 206276

Powered by Google App Engine
This is Rietveld 408576698