Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 15901008: Modify w3c import script to be able to run over a whole repo. (Closed)

Created:
7 years, 6 months ago by Dirk Pranke
Modified:
7 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Modify w3c import script to be able to run over a whole repo. This change allows us to run the import script over a whole repo, rather than just the 'submitted' and 'accepted' sub directories. This is another step towards being able to import and run the repos wholesale, rather than piecemeal. Most of the changes in this patch involve changes to handle malformed input files, log them, and continue. We need to continue to make things more robust here, and should start to add tests for this, but I'll defer this for now. Given that ultimately my goal is to make the import processes simpler rather than more complex, I want to defer writing tests for stuff I'm trying to delete. Once I get closer to have the script actually in the form we'll want long-term, and we'll want to support this properly, I'll make sure we have tests (right now, I'm the only one playing around with this). R=ojan@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151343

Patch Set 1 #

Patch Set 2 : add more FIXME comments for error handling #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -49 lines) Patch
M Tools/Scripts/webkitpy/w3c/test_converter.py View 5 chunks +17 lines, -11 lines 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_importer.py View 1 7 chunks +32 lines, -35 lines 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_parser.py View 1 2 chunks +17 lines, -3 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
7 years, 6 months ago (2013-05-28 23:24:10 UTC) #1
ojan
lgtm https://codereview.chromium.org/15901008/diff/5/Tools/Scripts/webkitpy/w3c/test_parser.py File Tools/Scripts/webkitpy/w3c/test_parser.py (right): https://codereview.chromium.org/15901008/diff/5/Tools/Scripts/webkitpy/w3c/test_parser.py#newcode88 Tools/Scripts/webkitpy/w3c/test_parser.py:88: print "Error: %s is has a reference link ...
7 years, 6 months ago (2013-05-28 23:45:54 UTC) #2
Dirk Pranke
7 years, 6 months ago (2013-05-29 01:23:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r151343 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698