Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 15901004: Issue 1015. Make 'double' type contagious in some binary expressions. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Issue 1015. Make 'double' type contagious in some binary expressions. https://code.google.com/p/dart/issues/detail?id=1015 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -23 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java View 4 chunks +49 lines, -19 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzerTest.java View 2 chunks +45 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 7 months ago (2013-05-23 20:17:17 UTC) #1
Brian Wilkerson
LGTM
7 years, 7 months ago (2013-05-23 20:27:07 UTC) #2
scheglov
7 years, 7 months ago (2013-05-23 20:37:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698