Add script to build Debian packages

tools/create_debian_packages.py

+#!/usr/bin/env python
+#
+# Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+# for details. All rights reserved. Use of this source code is governed by a
+# BSD-style license that can be found in the LICENSE file.
+#
+
+# Script to build a Debian packages from a Dart tarball. The script
+# will build a source package and a 32-bit (i386) and 64-bit (amd64)
+# binary packages.
+
+import sys
+import tarfile
+import subprocess
+import utils
+
+from os.path import join, exists, abspath
+from shutil import copyfile
+
+HOST_OS = utils.GuessOS()
+HOST_CPUS = utils.GuessCpus()
+DART_DIR = abspath(join(__file__, '..', '..'))
+
+def RunBuildPackage(opt, cwd):
+  cmd = ['dpkg-buildpackage', '-j%d' % HOST_CPUS]
+  cmd.extend(opt)
+  pipe = subprocess.Popen(cmd,

[kustermann, 2014/02/10 18:04:48]

It's not really a "pipe", maybe "process" would fit better.

[Søren Gjesse, 2014/02/11 10:21:57]

Done.

+                          stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+                          cwd=cwd)
+  (stdout, stderr) = pipe.communicate()
+  if pipe.returncode != 0:
+    raise Exception('Command \'%s\' failed: %s\nSTDOUT: %s' %
+                    (' '.join(cmd), str(stderr), str(stdout)))

[kustermann, 2014/02/10 18:04:48]

Are these str() conversions needed? Isn't it already a string?

[Søren Gjesse, 2014/02/11 10:21:57]

Removed (I copied the str() part from someplace else).

+
+def BuildDebianPackage():
+  version = utils.GetVersion()
+  builddir = join(DART_DIR, utils.GetBuildDir(HOST_OS, HOST_OS))
+  tarroot = 'dart-%s' % version
+  tarname = 'dart-%s.tar.gz' % version
+  tarball = join(builddir, tarname)
+  origtarball = join(builddir, 'dart_%s.orig.tar.gz' % version)
+  if not exists(join(builddir, tarball)):
+    print 'Source tarball not found'
+    return -1
+
+  copyfile(tarball, origtarball)
+
+  with tarfile.open(origtarball) as tar:
+    tar.extractall(path=builddir)

[kustermann, 2014/02/10 18:04:48]

I'd actually prefer if you used a temporary directory to do this work and only
put the final *.deb/*.tar.gz files into the build directory.

[Søren Gjesse, 2014/02/11 10:21:57]

OK, changed

+
+  # Build source package.
+  print "Building source package"
+  RunBuildPackage(['-S', '-us', '-uc'], join(DART_DIR, builddir, tarroot));

[kustermann, 2014/02/10 18:04:48]

I think you're constructing the wrong directory here:

  37 builddir = join(DART_DIR, utils.GetBuildDir(HOST_OS, HOST_OS)
     ...
  53 RunBuildPackage([...], join(DART_DIR, builddir, tarroot))

Isn't that pre-pending DART_DIR twice?

[Søren Gjesse, 2014/02/11 10:21:57]

Absolutely - fixed. As os.path.join "restarts" when meeting an absolute path it
still worked.

+
+  # Build 32-bit binary package.
+  print "Building i386 package"
+  RunBuildPackage(['-B', '-ai386', '-us', '-uc'],
+                  join(DART_DIR, builddir, tarroot));
+
+  # Build 64-bit binary package.
+  print "Building amd64 package"
+  RunBuildPackage(['-B', '-aamd64', '-us', '-uc'],
+                  join(DART_DIR, builddir, tarroot));
+
+  # Check the existence of the expected files.
+  debbase = 'dart_%s' % version
+  source_package = [
+    join(builddir, '%s-1.dsc' % debbase),
+    join(builddir, '%s.orig.tar.gz' % debbase),
+    join(builddir, '%s-1.debian.tar.gz' % debbase),
+  ]
+  i386_package = [
+    join(builddir, '%s-1_i386.deb' % debbase),
+  ]
+  amd64_package = [
+    join(builddir, '%s-1_amd64.deb' % debbase),
+  ]
+
+  for name in source_package:
+    assert exists(name)
+  for name in i386_package:
+    assert exists(name)
+  for name in amd64_package:
+    assert exists(name)
+
+def Main():
+  if HOST_OS != 'linux':
+    print 'Debian build only supported on linux'
+    return -1
+
+  BuildDebianPackage()
+
+if __name__ == '__main__':
+  sys.exit(Main())