content/renderer/render_widget.cc - Issue 1589953005: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget.cc

Issue 1589953005: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments in #38 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_widget.cc

diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc

index 2347d801fd5cabf4ced001e48a29f17a0b621d01..b8b4ad4f04dbf1d798a577b9a1235319a1539ecf 100644

--- a/content/renderer/render_widget.cc

+++ b/content/renderer/render_widget.cc

@@ -1578,10 +1578,6 @@ ui::TextInputType RenderWidget::GetTextInputType() {

}

void RenderWidget::UpdateCompositionInfo(bool should_update_range) {

-#if defined(OS_ANDROID)

-// TODO(yukawa): Start sending character bounds when the browser side

-// implementation becomes ready (crbug.com/424866).

-#else

TRACE_EVENT0("renderer", "RenderWidget::UpdateCompositionInfo");

gfx::Range range = gfx::Range();

if (should_update_range) {

@@ -1598,7 +1594,6 @@ void RenderWidget::UpdateCompositionInfo(bool should_update_range) {

composition_range_ = range;

Send(new InputHostMsg_ImeCompositionRangeChanged(

routing_id(), composition_range_, composition_character_bounds_));

-#endif

}

void RenderWidget::convertViewportToWindow(blink::WebRect* rect) {