content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java - Issue 1589953005: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

Issue 1589953005: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments in #38 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

index bebd6f09d2a9551a085ad96887b163ca642febe7..3728bf3b7482406dd2a3c28ea11feb691b98d6f6 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

@@ -601,9 +601,15 @@ public class ThreadedInputConnection implements ChromiumBaseInputConnection {

* @see InputConnection#requestCursorUpdates(int)

@Override

- public boolean requestCursorUpdates(int cursorUpdateMode) {

+ public boolean requestCursorUpdates(final int cursorUpdateMode) {

if (DEBUG_LOGS) Log.w(TAG, "requestCursorUpdates [%x]", cursorUpdateMode);

assertOnImeThread();

- return false;

+ ThreadUtils.postOnUiThread(new Runnable() {

+ @Override

+ public void run() {

+ mImeAdapter.onRequestCursorUpdates(cursorUpdateMode);

+ }

+ });

+ return true;

}